Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

CSS CSS Layout CSS Media Queries Media Queries

Posted by henry onyedum
henry onyedum
5,423 Points

what am i doing Wrong?

i have tried so many versions of my answer and ive played with the curly braces, what can i do differently?

style.css 
@media (min-width: 421px) {
  header{
    background: #294969;
    color: ghostwhite;
  }

 @media (min-width: 769px) { 
   #logo { font-size: 1.4rem; } 
   .h1 { font-size: 4rem; } 
  }
index.html 
<!DOCTYPE html>
<html lang="en">
<head>
  <meta charset="UTF-8">
  <meta name="viewport" content="width=device-width, initial-scale=1">
  <title>Developer Diane's blog</title>
  <link rel="stylesheet" href="page.css">
  <link rel="stylesheet" href="style.css">
</head>
<body>
  <header>
    <div id="logo">Developer Diane’s Blog</div>
  </header>
  <article>
    <section class="intro">
      <h1>The verdict is in. CSS Layout is great!</h1>
      <p>I’ve been working with CSS for a while now, and I have to say, it’s pretty awesome. I love being able to separate content from presentation, and to keep all my styles in an external stylesheet.</p>
      <p>I’ve had a pretty good grasp on the basics for a while now, but I needed to learn more about how to control layout with my CSS. Understanding CSS layout meant first exploring the parts of the CSS box model.</p>
    </section>
    <section class="featured">
      <h2>The CSS Box Model</h2>
      <p>There are lots of great resources online to help you learn the CSS Box Model. I like the CSS Tricks article <a href="https://css-tricks.com/the-css-box-model/" target="_blank">The CSS Box Model</a> by Chris Coyier. To quote the author:</p>
      <blockquote>At the risk of over-repeating myself: <strong>every element in web design is a rectangular box.</strong></blockquote>
      <p>That’s right! Every HTML element is considered by the browser to be a rectangular box.</p>
      <p>The CSS Box Model consists of four properties: content, padding, border, and margin. I've included a graphic from Coyier’s article to illustrate this principle.</p>
      <p class="clear">It’s pretty easy to understand the Content portion of the box model. The content is whatever your HTML consists of. It could be a paragraph full of text, or a bulleted list, or an image.</p>
      <p>Beginning developers may have some trouble keeping the other parts of the box model straight, so let’s examine them one by one.</p>
    </section>
    <footer>©2020 Developer Diane.</footer>
</body>
</html>

2 Answers

Jassim Alhatem
Jassim Alhatem
20,883 Points
Jassim Alhatem
Jassim Alhatem
20,883 Points

In your second media query, you're targeting the h1 class instead of the h1 element

henry onyedum
henry onyedum
5,423 Points

yes i had it as an element initially but i was just trying things. it keeps telling me that im not giving the right font size for the logo.

Jassim Alhatem
Jassim Alhatem
20,883 Points

oh then as Cameron said, add a closing curly brace and remove the (dot) from the h1.

Cameron Childres
Cameron Childres
11,817 Points
Cameron Childres
Cameron Childres
11,817 Points

Hi Henry,

You're missing a closing curly brace and without it the CSS is invalid. Close out your first media query then ensure h1 is targeting the element instead of class and you'll be good to go:

@media (min-width: 421px) {
  header{
    background: #294969;
    color: ghostwhite;
  }
}

@media (min-width: 769px) { 
  #logo { font-size: 1.4rem; } 
  h1 { font-size: 4rem; } 
}