What am I doing wrong here?

Question

Task:

Okay, so I need to count how many occurrences of a a specific letter is in the player's tiles. Let's build that over a couple of steps. I've added some example use cases in Example.java

Create a new method named getCountOfLetter that returns an int, and requires a parameter of type char named letter. For this task, just make it return 0.

I have written the code down below, I believe I got the if statement wrong in the tiles.toCharArray.

I have also tried replacing

return progress;

with

return 0;

and

return "0";

Please answer back!

ScrabblePlayer.java

public class ScrabblePlayer {
  // A String representing all of the tiles that this player has
  private String tiles;

  public ScrabblePlayer() {
    tiles = "";
  }

  public String getTiles() {
    return tiles;
  }

  public void addTile(char tile) {
    tiles += tile;
  }

  public boolean hasTile(char tile) {
    return tiles.indexOf(tile) != -1;
  }
  public int getCountOfLetter() {
    int progress = "";
    for (char letter : tiles.toCharArray()) {
      char display = '-;
      if (tiles.indexOf(letter) != -1 {
        display = tile;
      }
    }
    return progress;
  }
}

Example.java

// This code is here for example purposes only
public class Example {

  public static void main(String[] args) {
    ScrabblePlayer player1 = new ScrabblePlayer();
    player1.addTile('d');
    player1.addTile('d');
    player1.addTile('p');
    player1.addTile('e');
    player1.addTile('l');
    player1.addTile('u');

    ScrabblePlayer player2 = new ScrabblePlayer();
    player2.addTile('z');
    player2.addTile('z');
    player2.addTile('y');
    player2.addTile('f');
    player2.addTile('u');
    player2.addTile('z');

    int count = 0;
    // This would set count to 1 because player1 has 1 'p' tile in her collection of tiles
    count = player1.getCountOfLetter('p');
    // This would set count to 2 because player1 has 2 'd'' tiles in her collection of tiles
    count = player1.getCountOfLetter('d');
    // This would set 0, because there isn't an 'a' tile in player1's tiles
    count = player1.getCountOfLetter('a');

    // This will return 3 because player2 has 3 'z' tiles in his collection of tiles
    count = player2.getCountOfLetter('z');
    // This will return 1 because player2 has 1 'f' tiles in his collection of tiles
    count = player2.getCountOfLetter('f');
  }
}

Answer 1 · 2019-07-11T15:52:59Z

July 11, 2019 3:52pm

Loop over the tiles as a character array (as you are doing) and check to see if each tile is equal to the argument passed to the method (which you forgot to include):

public int getCountOfLetter(char letter) {
    int count = 0;
    for (char tile : tiles.toCharArray()) {
      if (tile == letter) {
        count++;
      }
    }
    return count;
  }

Answer 2 · 2019-07-16T03:17:42Z

July 16, 2019 3:17am

Data types are very important. And understanding what can be stored in what is important. In getCountOfLetter you are intializing int to "" which means you are trying to convert int to String in wrong way.

You can convert string to Integer using Wrapper classes but i dont think that is part of the current scope.

A few other mistakes i can see is if (tiles.indexOf(letter) != -1 , no closing bracket char display = '-;, missing closing symbol

And scribbles said above increment your count when you find a match

int indexOf(int ch): It returns the index of the first occurrence of character ch in a given String

IndexOf Char will always return the first ocurrence so i dont think we can use this here. So even if you have two 'd''s it will match just with first 'd' and return true

Welcome to the Treehouse Community

Looking to learn something new?

Tianerad 999

Tianerad 999

What am I doing wrong here?

Ken Alger

Ken Alger

2 Answers

scribbles

scribbles

Priyajot Syan

Priyajot Syan