Java Java Objects Delivering the MVP Applying a Discount Code

Jonas Støvring
Jonas Støvring
3,931 Points

what am i doing wrong here :O

Can anyone tell me what i am doing wrong here

Order.java
public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;

  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return discountCode;
  }

  public void applyDiscountCode(String discountCode) {
    this.discountCode = normalizeDiscountCode(discountCode);
  }




private String normalizeDiscountCode(String discountCode){
        for(char c : discountCode.toCharArray()) {
            if(!Character.isLetter(c) && c != '$') {
                throw new IllegalArgumentException("invalid discount code.");
            }
        }

        return discountCode.toUpperCase();

  }
Example.java
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

1 Answer

Jason Thomas
Jason Thomas
8,495 Points

I'm not sure why this doesn't work, but posting your error message would probably help somebody figure it out.

When I solved this I didn't use the enhanced for loop, but used a regular one so i could explicitly loop over discountCode (int i = 0; i < discountCode.length; i++) and used charAt(i) to grab each character.