Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

PHP

What am I doing wrong here? - Object Oriented PHP - Building the recipe - Controlling the Class code challenge

This is what I have, and it seems like it should work, but it keeps telling me that task one no longer passes.

<?php class Fish { public $common_name; public $flavor; public $record_weight;

public function getInfo() {
  return "A {$this->common_name} is an {$this->flavor} flavored fish. The world record weight is {$this->record_weight}.";
}
public function __construct($name, $flavor, $record) {
  $this->common_name = $name;
  $this->flavor = $flavor;
  $this->record_weight = $record;
}
$bass = new Fish();
$bass->name = "Largemouth Bass";
$bass->flavor = "Excellent";
$bass->record = "22 pounds 5 ounces";

}

1 Answer

Fredrik Lindhagen
Fredrik Lindhagen
20,913 Points

The problem is that you are trying to reference the parameters ($name, $flavor, $record) in the constructor-function, "through the object itself".

This technique is doable, however you have to point to the public properties ($common_name, $flavor $record_weight), instead of the constructor-parameters ($name, $flavor, $record)

The answer should then look something like this

<?php
$bass = new Fish();
$bass->common_name = "Largemouth Bass"; // Notice I'm not pointing to $name, but $common_name
$bass->flavor = "Excellent";
$bass->record_weight = "22 pounds 5 ounces";

Although the Treehouse task would accept this answer, I strongly recommend you instead place the values into the Fish-object when you instantiate it. This is faster and much more secure.

<?php
$bass = new Fish("Largemouth Bass", "Excellent", "22 pounds 5 ounces"); 

Hope this answers your question :)