Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Traversing the DOM Challenge: Using nextElementSibling

Tom Manger
Tom Manger
2,917 Points
Posted by Tom Manger
Tom Manger
2,917 Points

What am I doing wrong? insertAfter()

https://w.trhou.se/hrqiv6fvlu

const toggleList = document.getElementById('toggleList');
const listDiv = document.querySelector('.list');
const descriptionInput = document.querySelector('input.description');
const descriptionP = document.querySelector('p.description');
const descriptionButton = document.querySelector('button.description');
const listUl = listDiv.querySelector('ul');
const addItemInput = document.querySelector('input.addItemInput');
const addItemButton = document.querySelector('button.addItemButton');

listUl.addEventListener('click', (event) => {
  if (event.target.tagName == 'BUTTON') {
    if(event.target.className == 'remove'){
      let li = event.target.parentNode;
      let ul = li.parentNode;
      ul.removeChild(li);
    }
    if(event.target.className == 'up'){
      let li = event.target.parentNode;
      let prevLi = li.previousElementSibling;
      let ul = li.parentNode;
      if(prevLi){
        ul.insertBefore(li, prevLi);
      }
    }
     if(event.target.className == 'down'){
      let li = event.target.parentNode;
      let nextLi = li.nextElementSibling;
      let ul = li.parentNode;
      if(nextLi){
        ul.insertAfter(li, nextLi);
      }
    }
  }
});
Michael Anel
Michael Anel
7,469 Points
Michael Anel
Michael Anel
7,469 Points

There is no Node.insertAfter() DOM function in Javascript. Only when using JQuery. So I believe the code should be written as..

  let li = event.target.parentNode;
  let nextLi = li.nextElementSibling;
  let ul = li.parentNode;
  ul.insertBefore(nextLi, li);

1 Answer

Steven Parker
Steven Parker
231,521 Points
Steven Parker
Steven Parker
231,521 Points

As Michael pointed out, there's no "insertAfter" function. The functionality you want is available from the "insertAdjacentElement" function:

li.insertAdjacentElement("afterend", nextLi);

But using "insertBefore" with the arguments reversed is also a good choice.