Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

CSS CSS Basics (2014) Enhancing the Design With CSS Adjusting the Layout with Media Queries

Anthony Grodowski
Anthony Grodowski
4,902 Points

What am I doing wrong? I've checked whole code like 5 times and still cant find any mistake.

/* Web Fonts -------------------- */

@font-face {
  font-family: 'Abolition Regular';
  src: url('../fonts/abolition-regular-webfont.eot');
  src: url('../fonts/abolition-regular-webfont.eot?#iefix') format('embedded-opentype'),
       url('../fonts/abolition-regular-webfont.woff') format('woff'),
       url('../fonts/abolition-regular-webfont.ttf') format('truetype');
}



/* Base Styles -------------------- */

* {
  box-sizing: border-box;
}

body {
  color: #878787;
  margin: 0;
  font: 1em/1.5 "Helvetica Neue", Helvetica, Arial, sans-serif;
}

h1,
h2 {
  font-family: 'Abolition Regular', Helvetica, Arial, sans-serif; 
}

h1 {  
  font-size: 5.625rem; /* 90px/16px  */
  color: rgba(255, 255, 255, 1);
  text-transform: uppercase;
  font-weight: normal;
  line-height: 1.3;
  /*text-shadow: 5px 8px 10px #222;*/ /* first value: how much from right shadow should fall and second to the bottom third- blur fourth - color //u can also set negative shafow values to make it oursed to another side*/
  text-shadow: 0 1px 0 #ccc,
               0 2px 0 #c9c9c9,
               0 3px 0 #bbb,
               0 4px 0 #b9b9b9,
               0 5px 0 #aaa,
               0 6px 1px rgba(0,0,0,.1),
               0 0 5px rgba(0,0,0,.1),
               0 1px 3px rgba(0,0,0,.3),
               0 3px 5px rgba(0,0,0,.2),
               0 5px 10px rgba(0,0,0,.25),
               0 10px 10px rgba(0,0,0,.2),
               0 20px 20px rgba(0,0,0,.15);
/*  page layout cant be affected by shadow values*/
  margin: 12px 0 0;
}

h2 {
  font-size: 3.3125em; /* 53px/16px  */
  font-weight: normal;
  line-height: 1.1;
  margin: 0 0 .5em; /* 0 0 26px */
}

h3 {
  font-size: 1.25em; /* 20px/16px  */
  color: #48525c;
  line-height: 1.2;
  margin-bottom: 1.7em; /* 34px */
}

img {
  max-width: 100%;
  margin-bottom: 20px;
  border-radius: 10px;
}

ul,
ol {
  margin: 30px 0;
}

li {
  margin-bottom: 10px;
}

/* Pseudo-classes ------------------ */

a:link {
  color: rgb(255, 169, 73);
  text-decoration: none;
}

a:visited {
  color: lightblue;
}

a:hover {
  color: rgba(255, 169, 73, .4);
}

a:active {
  color: lightcoral;
}

/* Main Styles --------------------- */

.main-header {
  padding-top: 170px;
  height: 850px;
  background: linear-gradient(#ffa949, transparent 90%),
              linear-gradient(0deg, #fff, transparent),
              #ffa949 url('../img/mountains.jpg') no-repeat center;

  background-size: cover;

/*  background-image: *//*linear-gradient(45deg/circle/to top, #ffa949, firebrick);*/
/*                    radial-gradient(circle at top, #ffa949 0%, firebrick 50% , dodgerblue 100%);*/
/*  percentages order css to start each color at a particular part of the image*/
}

.title {
  color: white;
  font-size: 1.625rem; /* 26px/16px */
  letter-spacing: .065em;
  font-weight: 200;
  border-bottom: 2px solid;
  padding-bottom: 10px;
}

.intro {
  font-size: 1.25em; /* 20px/16px */
  line-height: 1.6;  
}

.primary-content,
.main-header,
.main-footer {
  text-align: center;
}

.primary-content {
    padding-top: 25px;
  padding-bottom: 95px;
}

.secondary-content {
    padding-top: 80px;
    padding-bottom: 70px;
  border-bottom: 2px solid #dfe2e6;
}

.callout {
  font-size: 1.25em;
  border-bottom: 3px solid;
  padding: 0 9px 3px;
  margin-top: 20px;
  display: inline-block;
}

.main-footer {
  padding-top: 60px;
  padding-bottom: 60px;
  border-bottom: 10px solid #ffa949;
}

.t-border {
  border-top: 2px solid #dfe2e6;
}

/* Layout Styles ------------------ */

.primary-content, 
.secondary-content {
  width: 75%;
  padding-left: 50px;
  padding-right: 50px;
  margin: auto;
  max-width: 960px;
}

.wildlife {
  color: white;
  text-align: left;
  padding: 18% 24%;
  border-top: 10px solid #ffa949;
  margin: 105px 0 60px;
  background: #434a52 url('../img/bear.jpg') no-repeat center;
  background-size: cover;
  box-shadow: inset 0 0 100px 50px rgba(0,0,0, 1);
/*  same value combination as in text shadow property*/
/*  fourth property (i mean decimal) is called spread value */
/*  inset means that the shadow lays in the element e.g. its "before border" so we can create inner progressing blackness*/
/*
  border-top-left-radius: 50px;
  border-top-right-radius: 10px;
  border-bottom-right-radius: 50px;
  border-bottom-left-radius: 10px;
*/
  border-radius: 50px 10px /*50px 10px*/;
/*
.arrow {
  width: 5px;
  max-width: 60px;
}
*/

/* Floated Columns ------------------ */

.resorts,
.tips {
  width: 46.5%;
}

.tips {
  float: left;
}

.resorts {
  float: right;
}

/* Float Clearfix ------------------ */

.group:after {
  content: "";
  display: table;
  clear: both;
}

/* Media Queries ------------------ */

@media (max-width: 1024px) {
      .primary-content,
      .secondary-content {
        width: 90%;
      }

      .wildlife {
        padding: 10% 12%;
        margin: 50px 0 20px;
      }
  }


@media (max-width: 768px) {
      .primary-content,
      .secondary-content{
        width: 100%;
        padding: 20px;
        border-top: none;
      }
        .main-header {
        max-height: 380px;
        padding: 50px 25px 0;
      }

      .title {
        font-size: 1.3rem;
        border: none;
      }

      h1 {
        font-size: 5rem;
        line-height: 1.1;
      }

      .intro {
        font-size: 1rem;
      }

      .resorts,
      .tips {
        float: none;
        width: 100%;
      }

      .main-footer {
          padding: 20px 0;
      }
    }

MOD: Added formatting to make the code easier to read. See the Markdown Cheatsheet linked just below the textboxes for how to do this - don't worry, it's easy!

1 Answer

Louise St. Germain
Louise St. Germain
19,424 Points

Hi Antoni,

It's hard to tell without seeing the whole thing in action, but from the look of it (and the red colouring on the .resort and .tips classes!), it seems like you're missing the closing curly brace that should go at the end of the .wildlife class. If you add that in, does it help anything?

If not, can you be more specific about what isn't working?

Thanks!

Anthony Grodowski
Anthony Grodowski
4,902 Points

Thank you! After the missing curly brace at the end of the wildlife rule everything started working except for floating. Images in .tips and .resorts aren't floating as they should be. What does it mean that theyre marked as red? How can i fix that?

Louise St. Germain
Louise St. Germain
19,424 Points

Hi Antoni,

Red code in the markup usually indicates that there's a syntax error somewhere in the vicinity (either right there or somewhere before it). That said, in Workspaces, there's often red highlighter on perfectly valid media queries - not sure why!

In any case, hmm, not sure why your floats aren't working, and it's hard to tell without being able to see the full HTML and how everything is behaving. How wide is your viewport? I'm wondering if you're on a narrower viewport (or on phone or tablet), maybe it's triggering the "float: none" rule that you have on those classes down in the media query for max-width of 768? Does the float behaviour of those classes change as you make the viewport wider and narrower?