Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Basics (Retired) Creating Reusable Code with Functions Create a max() Function

Luis Paulino
Luis Paulino
Courses Plus Student 1,779 Points

what do I do now?

I don't know what to do now. It passed with a string, but now it wants numbers.

function max(five,eight){
  return eight;

1 Answer

Steven Parker
Steven Parker
229,005 Points

You have a semicolon after the conditional expression of your if statement — that makes it a "no-op" (does nothing).

After removing it, you'll also need to add another return statement to handle the cases where the condition is not true.

So your function will look something like this:

function max(five, eight) {
  if (eight>five)
    return eight;
  return five;

And while it's perfectly legitimate from the programming language standpoint, I find the use of number names being used as the variables makes it a bit confusing to read (though somewhat humorous).

Happy coding!   -sp:sparkles:

jose macedo
jose macedo
6,041 Points

thanks i had the same problem with this