Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Python Collections (2016, retired 2019) Dungeon Game Hit points

Posted by Elias Helander
Elias Helander
1,461 Points

What is wrong?

It gets the wrong value. What am I doing wrong?

movement.py 
# EXAMPLES:
# move((1, 1, 10), (-1, 0)) => (0, 1, 10)
# move((0, 1, 10), (-1, 0)) => (0, 1, 5)
# move((0, 9, 5), (0, 1)) => (0, 9, 0)

def move(player, direction):
    x, y, hp = player
    a, b = direction
    if x + a > 0:
        x += 0
        hp -= 5
    if x + a < 9:
        x += 0
        hp-=5
    if y + b > 0:
        y += 0
        hp -= 5
    if y + b < 9:
        y += 0
        hp-=5

    return x, y, hp

1 Answer

Tomas Svojanovsky
Tomas Svojanovsky
26,680 Points
Tomas Svojanovsky
Tomas Svojanovsky
26,680 Points

Hello, you don't solve the situation when it is ok and too many ifs 

def move(player, direction):
    x, y, hp = player
    toX, toY = direction

    if x + toX < 0 or y + toY < 0 or x + toX > 9 or y + toY > 9:
        hp -= 5
    else:
        x += toX
        y += toY

    return x, y, hp