Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Python Basics (2015) Shopping List App Refactor

what is wrong with my code

Challenge Task 1 of 1

This challenge is a little different. You shouldn't have to write very much code.

You probably recognize this code. It's pretty much our shopping_list_2.py from before. I want you to help me with a little refactor, though. Refactoring is when we change code to make it better, often by creating new functions.

Create a new function named main that doesn't take any arguments.

Move everything from line 22 (show_help()) and below into your new function. You shouldn't have any code that isn't inside of a function.

def show_help():
    # print out instructions on how to use the app
    print("What should we pick up at the store?")
Enter 'DONE' to stop adding items.
Enter 'HELP' for this help.
Enter 'SHOW' to see your current list.

def show_list(shopping_list):
    # print out the list
    print("Here's your list:")

    for item in shopping_list:

def add_to_list(shopping_list, new_item):
    # add new items to our list
    print("Added {}. List now has {} items.".format(new_item, len(shopping_list)))
    return shopping_list
def main(): 

    # make a list to hold onto our items
    shopping_list = []

    while True:
    # ask for new items
    new_item = input("> ")

    # be able to quit the app
    if new_item == 'DONE':
    elif new_item == 'HELP':
    elif new_item == 'SHOW':
    add_to_list(shopping_list, new_item)


1 Answer

Taylor Schimek
Taylor Schimek
19,318 Points

Very close. Try indenting everything in the while loop.

Thanks Taylor!! I had to indent everything after while including the very last code for me to pass.