Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python

Posted by Hamida Ali
Hamida Ali
3,388 Points

what is wrong with my code

Challenge Task 2 of 2 Now update Hand in hands.py. I'm going to use code similar to Hand.roll(2) and I want to get back an instance of Hand with two D20s rolled in it. I should then be able to call .total on the instance to get the total of the two dice.

I'll leave the implementation of all of that up to you. I don't care how you do it, I only care that it works.

Bummer: Hand doesn't have a roll method 

dice.py
hands.py

classmethod
import random
ā€‹
class Die:
    def __init__(self, sides=2):
        if sides < 2:
            raise ValueError("Can't have fewer than two sides")
        self.sides = sides
        self.value = random.randint(1, sides)

    def __int__(self):
        return self.value

    def __add__(self, other):
        return int(self) + other

    def __radd__(self, other):
        return self + other

class D20(Die):
    def __init__(self):
        super().__init__(sides=20)

from dice import D20
ā€‹
class Hand(list):
    def __init__(self, x):
        super().__init__()
        self.extend(x)
ā€‹
@property
def total(self):
    return sum(self)      
ā€‹
@classmethod
def roll(cls,size, die_class =D20):
    x = []
    for _ in range(size):
        x.append(die_class())
    return cls(x)

[MOD: added ```python formatting -cf]

1 Answer

Chris Freeman
MOD
Chris Freeman
Treehouse Moderator 68,423 Points
Chris Freeman
Chris Freeman
Treehouse Moderator 68,423 Points

It appears that the methods of the Hand class are not properly indented. Both the total and roll methods should be indented the same amount as the __init__() method.

Post back if you need more help. Good luck!!

Hamida Ali
Hamida Ali
3,388 Points

thanx..but still getting the same problem

class D20(Die):
    def __init__(self):
        super().__init__(sides=20)

from dice import D20

class Hand(list):
    def __init__(self, x):
        super().__init__()
        self.extend(x)

    @property
    def total(self):
        return sum(self)      

    @classmethod
    def roll(cls,size, die_class =D20):
        x = []
        for _ in range(size):
            x.append(die_class())
        return cls(x)
Hamida Ali
Hamida Ali
3,388 Points

i saw i was updating the wrong thing thank you!