Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

JavaScript Asynchronous Programming with JavaScript Understanding Promises Handle Multiple Promises with Promise.all

Joshua Ouma
Joshua Ouma
20,362 Points

What is wrong with my code? Someone help

TypeError: Cannot read property 'source' of undefined at promises.js:35 at Array.map (<anonymous>) at generateHTML (promises.js:31) Below is my code:

const astrosUrl = 'http://api.open-notify.org/astros.json';
const wikiUrl = 'https://en.wikipedia.org/api/rest_v1/page/summary/';
const peopleList = document.getElementById('people');
const btn = document.querySelector('button');

function getJSON(url) {
  return new Promise((resolve,reject)=>{
    const xhr = new XMLHttpRequest();
    xhr.open('GET', url);
    xhr.onload = () => {
      if(xhr.status === 200) {
      let data = JSON.parse(xhr.responseText);
       resolve(data);
      }else{
        reject(Error(xhr.statusText));
      }
    xhr.onerror = reject(Error("A network error occured"));
    };
    xhr.send();
  });
}

function getProfiles(json) {
  const profile = json.people.map( person => {
    return getJSON(wikiUrl + person.name);      
  }); 
  return Promise.all(profile);
}

function generateHTML(data) {
   data.map( person =>{
      const section = document.createElement('section');
      peopleList.appendChild(section);
      section.innerHTML = `
      <img src=${person.thumbnail.source}>
      <h2>${person.title}</h2>
      <p>${person.description}</p>
      <p>${person.extract}</p>
    `;
  });
}


btn.addEventListener('click', (event) => {
  event.target.textContent = "Loading...";
  getJSON(astrosUrl)
    .then(getProfiles)
    .then(generateHTML)
    .catch(err => {
      peopleList.innerHTML = "<h3>Something went wrong</h3>";
      console.log(err)
    })
    .finally(event.target.remove());
});

2 Answers

Hi Joshua,

The error is caused by 'thumbnail' not being defined. You are referencing a property that doesn't exist.

<img src=${person.thumbnail.source}>

The json you are sourcing from combining your two Urls is returning data - some of which do not contain 'thumbnail' You will have to put in a condition to test to see if the data is defined before trying to use it.

You could use something like this :

if (typeof person.thumbnail !== 'undefined') {
    // is defined
}
Brendan Moran
Brendan Moran
14,052 Points

To troubleshoot this, use console.log(data) to see what you are dealing with before the error occurs. Put it in the first line of the generateHTML function. You might see that one of the profiles failed to come back from wikipedia. If that's the case, look at some of the other questions and answers on this video that deal with that problem.