Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

Python

What is wrong with my Letter Game? (letter_game.py)

import os
import sys
import random

# Make a list of words
words = ["apple", "banana", "orange", "coconut", "strawberry", "lime", "grapefruit", "lemon", "kumquat", "blueberry", "melon"]

def clear():
  if os.name == "nt":
    os.system("cls")
  else:
    os.system("clear")

def draw(bad_guesses, good_guesses, secret_word):
  clear()

  print("strikes: {}/7".format(len(bad_guesses)))
  print("")

  for letter in bad_guesses:
    print(letter,end=" ")
  print("\n\n")

  for letter in secret_word:
    if letter in good_guesses:
      print(letter, end="")
    else:
      print("_", end="")

  print("")

def get_guess(bad_guesses, good_guesses):
  while True:
    guess = input("Guess a letter: ").lower()

    if len(guess) != 1:
      print("You can only guess a single letter!")
    elif guess in bad_guesses or guess in good_guesses:
      print("You've already guessed that letter!")
    elif not guess.isalpha():
      print("You can only guess letters!")
    else:
      return guess

def play(done):
  clear()
  secret_word = random.choice(words)
  bad_guesses = []
  good_guesses = []

  while True:
    draw(bad_guesses, good_guesses, secret_word)
    guess = get_guess(bad_guesses, good_guesses)

    if guess in secret_word:
      good_guesses.append(guess)
      found = True
      for letter in secret_word:
        if letter not in good_guesses:
          found = False
      if found:
        print("you win!")
        print("The secret word was {}".format(secret_word))
    else:
      bad_guesses.append(guess)
      if len(bad_guesses) == 7:
        draw(bad_guesses,good_guesses, secret_word)
        print("You lost!")
        print("The secret word was {}".format(secret_word))
        done = True

    if done:
      play_again = input("Play again? Y/n ").lower()
      if play_again != "n":
        return play(done=False)
      else:
        sys.exit()


def welcome():
  start = input("Press enter/return to start or Q to quit ").lower()
  if start == "q":
    print("Bye!")
  else:
    return True

print("Welcome to Letter Guess!")

done = False

while True:
  clear()
  welcome()
  play(done)

My code works fine but it continues on even after finding the word, ie, i don't receive the messages;

"You win!" "The secret word was.." "Play again? Y/n "

Please help.

1 Answer

Mike Brooks
Mike Brooks
3,389 Points

Around line 72, you have:

            if found:
                print("You win!")
                print("The secret word was {}".format(secret_word))

At the end of the if found:, since you won try setting:

done = True immediately after the above code.