Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Regular Expressions in JavaScript Validating a Form Form Validation

Posted by Henry Nguyen
.a{fill-rule:evenodd;}techdegree
Henry Nguyen
Full Stack JavaScript Techdegree Student 5,153 Points

What is wrong with this reg ex?

It works in a regex tester but the challenge says it matches non-hexadecimal values too.

app.js 
// Type inside this function
function isValidHex(text) {
  const hexRegEx= /#(\d|[a-f]){6}/i;
}

const hex = document.getElementById("hex");
const body = document.getElementsByTagName("body")[0];

hex.addEventListener("input", e => {
  const text = e.target.value;
  const valid = isValidHex(text);
  if (valid) {
    body.style.backgroundColor = "rgb(176, 208, 168)";
  } else {
    body.style.backgroundColor = "rgb(189, 86, 86)";
  }
});
index.html 
<!DOCTYPE html>
<html>

<head>
    <title>DOM Manipulation</title>
</head>
<link rel="stylesheet" href="style.css" />

<body>
    <div id="content">
        <p>Enter a valid hex value below to make the screen turn green.</p>
        <input type="text" id="hex">
    </div>
    <script src="app.js"></script>
</body>

</html>

1 Answer

Steven Parker
Steven Parker
229,744 Points
Steven Parker
Steven Parker
229,744 Points

You're close, but the regex needs to be "anchored" to the beginning and end of the string:

  const hexRegEx = /^#(\d|[a-f]){6}$/i;

Also, it's a bit more conventional to include the digits in the character class ("[0-9a-f]"), and then the grouping and branching isn't needed.