Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript jQuery Basics (2014) Creating a Simple Lightbox Adding New Attribute Values with attr()

Alcuin Guest
Alcuin Guest
4,496 Points
Posted by Alcuin Guest
Alcuin Guest
4,496 Points

What is wrong with this short line of code? (J-Query)

$(".external a").attr( "target", "_blank");

From J-Query Basics course, Lightbox section, code challenge.

js/app.js 
$(".external a").attr( "target", "_blank");
index.html 
<!DOCTYPE html>
<html>
<head>
  <link rel="stylesheet" href="css/style.css" type="text/css" media="screen" title="no title" charset="utf-8">
  <title>Links Page</title>
</head>
<body>
  <h1>Links</h1>
  <ul>
    <li><a href="http://google.com" class="external">Google</a></li>
    <li><a href="http://yahoo.com" class="external">Yahoo</a></li>
  </ul>
  <script src="//code.jquery.com/jquery-1.11.0.min.js" type="text/javascript" charset="utf-8"></script>
  <script src="js/app.js" type="text/javascript" charset="utf-8"></script>
</body>
</html>

3 Answers

Steven Parker
Steven Parker
229,732 Points
Steven Parker
Steven Parker
229,732 Points

The selector ".external a" targets anchors that are descendants of elements that have class external.

:point_right: You probably want "a.external" to target anchors which have that class themselves.

Carlos Federico Puebla Larregle
Carlos Federico Puebla Larregle
21,073 Points
Carlos Federico Puebla Larregle
Carlos Federico Puebla Larregle
21,073 Points

Select the element first and then see if it has the ".external" class. You could do it like this:

 $("a.external").attr( "target", "_blank");

I hope that helps.