Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

Java Java Objects Creating the MVP Scrabble Tiles

Valentin Zachesov
Valentin Zachesov
625 Points

What's wrong? I'm confused

I do not understand what are you asking. In last video the only way you taught was by using "if/else".

ScrabblePlayer.java
public class ScrabblePlayer {
  // A String representing all of the tiles that this player has
  private String tiles;

  public ScrabblePlayer() {
    tiles = "";
  }

  public String getTiles() {
    return tiles;
  }

  public void addTile(char tile) {
    tiles += tile;

  }

  public boolean hasTile(char tile) {
   boolean win = tiles.indexOf(tile) != -1; 
    return true;

   boolean win1 = tiles.indexOf(tile) != -1; 
    return false;



  }

}

1 Answer

andren
andren
28,538 Points

The expression tiles.indexOf(tile) != -1 returns a boolean, it is true if the tile is in tiles and false if not. That is also the exact same thing the method is meant to return.

If you use an if statement you are essentially saying "if this expression is true return true, if it is false return false" which is clearly a redundant thing to do.

The efficient solution and the one the task is looking for is to return the expression directly like this:

public boolean hasTile(char tile) {
   return tiles.indexOf(tile) != -1; 
}