Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

Java Java Objects Delivering the MVP Applying a Discount Code

shayne elmore
shayne elmore
1,961 Points

Whats wrong with my code?

It's telling me after I submit that my question 1 is wrong? I'm only adding to the pre-existing code from question 1 when I submit 2 and it tells me I'm wrong.

Order.java
public class Order {
  private String itemName;
  private int priceInCents;
  private String discountCode;



  public Order(String itemName, int priceInCents) {
    this.itemName = itemName;
    this.priceInCents = priceInCents;
  }

  private String normalizeDiscountCode(String discountCode) {
    if(!discountCode.matches("[a-z$]")) {
        throw new IllegalArgumentException("Invalid discount code.");                      
       }
    return discountCode.toUpperCase();
  }

  public String getItemName() {
    return itemName;
  }

  public int getPriceInCents() {
    return priceInCents;
  }

  public String getDiscountCode() {
    return discountCode;
  }

  public void applyDiscountCode(String discountCode) {
    this.discountCode = normalizeDiscountCode(discountCode);
  }
}
Example.java
public class Example {

  public static void main(String[] args) {
    // This is here just for example use cases.

    Order order = new Order(
            "Yoda PEZ Dispenser",
            600);

    // These are valid.  They are letters and the $ character only
    order.applyDiscountCode("abc");
    order.getDiscountCode(); // ABC

    order.applyDiscountCode("$ale");
    order.getDiscountCode(); // $ALE


    try {
      // This will throw an exception because it contains numbers
      order.applyDiscountCode("ABC123");
    } catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }
    try {
      // This will throw as well, because it contains a symbol.
      order.applyDiscountCode("w@w");
    }catch (IllegalArgumentException iae) {
      System.out.println(iae.getMessage());  // Prints "Invalid discount code"
    }

  }
}

1 Answer

shayne elmore
shayne elmore
1,961 Points

That's causing my task 1 to be wrong?

Craig Dennis
Craig Dennis
Treehouse Teacher

Yes I think so. The first task makes sure that you:

return the uppercase version

You are no longer doing that, you are blocking the code before it gets there. Imagine discount code being "Abc" would it pass your if statement?

shayne elmore
shayne elmore
1,961 Points

Not related, but is it possible to go back through the java basics course? I feel like there are holes in my knowledge of certain concepts that I may have missed during the first course. I just want to make sure I'm on a good page, and actually know the material before moving forward anymore with my techdegree.