Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python

Posted by norman cole
norman cole
2,756 Points

Whats wrong with my code

Alright, here's a fun task! Create a function named combiner that takes a single argument, which will be a list made up of strings and numbers. Return a single string that is a combination of all of the strings in the list and then the sum of all of the numbers. For example, with the input ["apple", 5.2, "dog", 8], combiner would return "appledog13.2". Be sure to use isinstance to solve this as I might try to trick you.

instances.py 
def combiner(list1):
num = 0
string = ""

    for item in list1:
        if isinstance(item, str):
            string += item

        elif isinstance(item, (int, float)):
            num += item

        return string + str(num)

1 Answer

Greg Kaleka
Greg Kaleka
39,021 Points
Greg Kaleka
Greg Kaleka
39,021 Points

Hi Norman,

The problem is indentation! Python is really particular about indentation. Here's how it should look:

def functionname():  # indented 0
    variable  # indented 1
    variable  # indented 1

    for item in list:  # indented 1
        do_stuff  # indented 2
    return value  # indented 1

Fix your indentation, and the rest of your function looks good!

Cheers :beers:

-Greg