Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript AJAX Basics (retiring) Programming AJAX Processing JSON Data

what's wrong with my code?

var xhr = new XMLHttpRequest(); xhr.onreadystatechange = function () { if (xhr.readyState === 4) { var employees = JSON.parse(xhr.responseText); var statusHTML = '<ul class="bulleted">'; for(var i=0; i<employees.length; i += 1) { if(employees[i].inoffice === true) { statusHTML = '<li class="in">'; }else { statusHTML = '<li class="out">'; } statusHTML += employees[i].name; statusHTML += '</li>'; } statusHTML += '</ul>'; document.getElementById('employeeList').innerHTML = statusHTML;
} }; xhr.open('GET', 'data/employees.json'); xhr.send();

1 Answer

Full Stack JavaScript Techdegree Student 16,610 Points

This piece of code:

            if (employees[i].inoffice === true) {
                statusHTML = '<li class="in">';
            } else {
                statusHTML = '<li class="out">';

You're setting the string equal to the <li> tags instead of adding them onto what you have. This erases what was previously written. So just use the += operator.

            if (employees[i].inoffice === true) {
                statusHTML += '<li class="in">';
            } else {
                statusHTML += '<li class="out">';

Additionally, you may want to look into markdown to make your post easier to read. This can help improve your chances of getting an answer.