Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Making Changes to the DOM Removing Nodes

Posted by Serge Zant
Serge Zant
10,420 Points

Whats wrong with my code?

const toggleList = document.getElementById('toggleList'); const listDiv = document.querySelector('.list');

const descriptionInput = document.querySelector('input.description'); const descriptionP = document.querySelector('p.description'); const descriptionButton = document.querySelector('button.description');

const addItemInput = document.querySelector('input.itemInput'); const addButton = document.querySelector('button.addButton');

const removeItemButton = document.querySelector('button.removeItemButton');

toggleList.addEventListener('click', () => { if(listDiv.style.display == 'none') { toggleList.textContent = 'Hide list'; listDiv.style.display = 'block'; } else { toggleList.textContent = 'Show list'; listDiv.style.display = 'none'; } });

descriptionButton.addEventListener('click', () => { descriptionP.innerHTML = descriptionInput.value + ':'; descriptionP.value = ''; });

addButton.addEventListener('click', () => { let ul = document.getElementsByTagName('ul')[0]; let li = document.createElement('li'); li.textContent = addItemInput.value; ul.appendChild(li); addItemInput.value = ''; });

removeItemButton.addEventListener('click', () => { let ul = document.getElementsByTagName('ul')[0]; let li = document.querySelector('li:last-child'); ul.removeChild(li); });

3 Answers

Aakash Srivastav
seal-mask
.a{fill-rule:evenodd;}techdegree
Aakash Srivastav
Full Stack JavaScript Techdegree Student 11,638 Points
Aakash Srivastav
.a{fill-rule:evenodd;}techdegree
Aakash Srivastav
Full Stack JavaScript Techdegree Student 11,638 Points

Hey Serge Zant , you have done really very well , just few variable name mistakes :

  1. You have to use addItemInput instead of itemInput in line 4 of your above code
  2. You have to use addItemButton instead of addButton in line 5 of your above code.

So your final code would be :

const toggleList = document.getElementById('toggleList');
const listDiv = document.querySelector('.list');
const descriptionInput = document.querySelector('input.description');
const descriptionP = document.querySelector('p.description');
const descriptionButton = document.querySelector('button.description');
const addItemInput = document.querySelector('input.addItemInput');      // I have used 'input.addItemInput' in place of input.itemInput
const addButton = document.querySelector('button.addItemButton');     // I have used 'button.addItemButton' in place of addButton
const removeItemButton = document.querySelector('button.removeItemButton');

toggleList.addEventListener('click', () => {
    if (listDiv.style.display == 'none') {
        toggleList.textContent = 'Hide list';
        listDiv.style.display = 'block';
    } else {
        toggleList.textContent = 'Show list';
        listDiv.style.display = 'none';
    }
});

descriptionButton.addEventListener('click', () => {
    descriptionP.innerHTML = descriptionInput.value + ':';
    descriptionP.value = '';
});

addButton.addEventListener('click', () => {
    let ul = document.getElementsByTagName('ul')[0];
    let li = document.createElement('li');
    li.textContent = addItemInput.value;
    ul.appendChild(li);
    addItemInput.value = '';
});

removeItemButton.addEventListener('click', () => {
    let ul = document.getElementsByTagName('ul')[0];
    let li = document.querySelector('li:last-child');
    ul.removeChild(li);
});

Hope , you have got your answer :)

Serge Zant
Serge Zant
10,420 Points
Serge Zant
Serge Zant
10,420 Points

Hey Aakash, I Changed the code. How can i use a more readable code block?

Serge Zant
Serge Zant
10,420 Points
Serge Zant
Serge Zant
10,420 Points

Ahhh thank you so much! I really could'nt spot the problem. Thank you for helping!