Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Ruby Ruby Objects and Classes Build a Bank Account Class Implement the balance Method

Patrick Mockridge
.a{fill-rule:evenodd;}techdegree seal-36
Patrick Mockridge
Full Stack JavaScript Techdegree Graduate 45,611 Points

What's wrong with my code?

Not sure where I'm going wrong. Help?

class BankAccount
  attr_reader :name

  def initialize(name)
    @name = name
    @transactions = []
    add_transaction("Beginning Balance", 0)

  def debit(description, amount)
    add_transaction(description, -amount)

  def credit(description, amount)
    add_transaction(description, amount)

  def add_transaction(description, amount)
    @transactions.push(description: description, amount: amount)

  def balance
    balance = 0
    @transactions.each do |debit|
      balance += debit[:amount]
    @transactions.each do |credit|
      balance += credit[:amount]


1 Answer

Steve Chen
Steve Chen
10,090 Points

you don't need to loop through twice - since credit is already going to subtract and debit is going to add. So once is enough to get the job done.

Another thing you forgot to return balance once the loop is finished.