Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

HTML How to Make a Website Responsive Web Design and Testing Adjust the Profile Page and Header

Posted by Adam Butcher
.a{fill-rule:evenodd;}techdegree
Adam Butcher
Front End Web Development Techdegree Student 12,180 Points

When I float my profile picture, the header goes down and there is a little bit of white space on the top.

I added the float-left property as in the video, and there is a small bit of white space. I clicked the other links and they are normal without white space.

.profile-photo { float:left; margin: 0 5% 80px 0; }

I know if I take out the float:left, it leaves the header alone. But when I add it in, it goes down.

5 Answers

Serge Kagiema - Fay
Serge Kagiema - Fay
2,879 Points
Serge Kagiema - Fay
Serge Kagiema - Fay
2,879 Points

Can you provide your html and css code?

Serge Kagiema - Fay
Serge Kagiema - Fay
2,879 Points
Serge Kagiema - Fay
Serge Kagiema - Fay
2,879 Points

In your css add the following:

header { //previous css code overflow: hidden; }

//#wrapper

wrapper {

padding-top: 67px;

}

Then try to float your profile image left or right. No more spaces.

Adam Butcher
seal-mask
.a{fill-rule:evenodd;}techdegree
Adam Butcher
Front End Web Development Techdegree Student 12,180 Points
Adam Butcher
.a{fill-rule:evenodd;}techdegree
Adam Butcher
Front End Web Development Techdegree Student 12,180 Points

about.html

<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8">
    <title>Adam Butcher | Software Engineer</title>
    <link rel="stylesheet" href="css/normalize.css">
    <link href="https://fonts.googleapis.com/css?family=Changa+One|Open+Sans:400,400i,700,700i,800" rel="stylesheet">
    <link rel="stylesheet" href="css/main.css">
    <link rel="stylesheet" href="css/responsive.css">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
  </head>
  <body>
    <header>
      <a href="index.html" id="logo">
        <h1>Adam Butcher</h1>
        <h2>Software Engineer</h2>
      </a>
      <nav>
        <ul>
          <li><a href="index.html">Portfolio</a></li>
          <li><a href="about.html" class="selected">About</a></li>
          <li><a href="contact.html">Contact</a></li>
        </ul>
      </nav>
    </header>
    <div id="wrapper">
      <section>
        <img src="img/6LJoah8.png" alt="photo" class="profile-photo">
        <h3>About</h3>
        <p>Adam Butcher is a recent Computer Science graduate from the University of Texas at Dallas looking for a job.</p>
      </section>
      <footer>
        <p>&copy; 2016 Adam Butcher.</p>
      </footer>
    </div>
  </body>
</html>

responsive.css

@media screen and (min-width: 480px) {

  /*********************
  TWO COLUMN LAYOUT
  **********************/

  #primary {
    width: 50%;
    float: left;
  }

  #secondary {
    width: 40%;
    float: right;
  } 

  /*********************
  PAGE: PORTFOLIO
  **********************/

  #gallery li {
    width: 28.3333%;
  }

  #gallery li:nth-child(4n) {
    clear:left;
  }

  /*********************
  PAGE: ABOUT
  **********************/

  .profile-photo {
    /*float:left;*/
    margin: 0 5% 80px 0;
  }

}

@media screen and (min-width: 660px) {


  /*********************
  HEADER
  **********************/

  nav {
    background: none;
    float: right;
    font-size: 1.125em;
    margin-right: 5%;
    text-align: right;
    width: 45%;
  }

  #logo {
    float: left;
    margin-left: 5%;
    text-align: left;
    width: 45%;
  }

  h1 {
    font-size: 2.5em;
  }

  h2 {
    font-size: 0.825em;
    margin-bottom: 20px;
  }

  header {
    border-bottom: 5px solid #599a68;
    margin-bottom: 60px;
  }
}

main.css

/*********************
GENERAL
**********************/

body {
  font-family: 'Open Sans', sans-serif;
}

#wrapper {
  max-width: 940px;
  margin: 0 auto;
  padding: 0 5%;
}

a {
  text-decoration: none;
}

img {
  max-width: 100%;
}

/*********************
HEADING
**********************/

header {
  float: left;
  margin: 0 0 30px 0;
  padding 5px 0 0 0;
  width: 100%;
}

#logo {
  text-align: center;
  margin: 0;
}

h1 {
  font-family: 'Changa One', sans-serif;
  margin: 15px 0;
  font-size: 1.75em;
  font-weight: normal;
  line-height: 0.8em;
}

h2 {
  font-size: 0.75em;
  margin: -5px 0 0;
  font-weight: normal;
}

/*********************
NAVIGATION
**********************/

nav {
  text-align: center;
  padding: 10px 0;
  margin: 20px 0 0;
}

nav ul {
  list-style: none;
  margin: 0 10px;
  padding: 0;
}

nav li {
  display: inline-block;
}

nav a {
  font-weight: 800;
  padding: 15px 10px;
}

/*********************
FOOTER
**********************/
footer {
  font-size: 0.75em;
  text-align: center;
  clear: both;
  padding-top: 50px;
  color: #ccc;
}

/*********************
PAGE: PORTFOLIO
**********************/

#gallery {
  margin: 0;
  padding: 0;
  list-style: none;
}

#gallery li {
  float: left;
  width: 45%;
  margin: 2.5%;
  background-color: #f5f5f5;
  color: #bdc3c7;
}

#gallery li a p {
  margin: 0;
  padding: 5%
  font-size: 0.75em;
  color: #bdc3c7
}

/*********************
PAGE: ABOUT
**********************/

.profile-photo {
  display: block;
  max-width: 150px;
  margin: 0 auto 30px;
  border-radius: 100%;
}


/*********************
PAGE: CONTACT
**********************/

.contact-info {
  list-style: none;
  padding: 0;
  margin: 0;
  font-size; 0.9em;
}

.contact-info a {
  display: block;
  min-height: 20px;
  background-repeat: no-repeat;
  background-size: 20px 20px;
  padding: 0 0 0 30px;
  margin: 0 0 10px;
}

.contact-info li.phone a {
  background-image: url('../img/phone.png');
}

.contact-info li.mail a{
  background-image: url('../img/mail.png');
}

.contact-info li.twitter a{
    background-image: url('../img/twitter.png');
}

/*********************
COLORS
**********************/

/* site body */
body {
  background-color: #fff;
  color: #999;
}

/* green header */
header {
  background: #6ab47b;
  border-color: #599a68;
}

/* nav background on mobile devices */
nav {
  background: #599a68;
}

/* logo text */
h1, h2 {
  color: #fff;
}

/* links */
a {
  color: #6ab47b;
}

/* nav link */
nav a, nav a:visited {
  color: #fff;
}

/* selected nav link */
nav a.selected, nav a:hover{
  color: #32673f;
}
Serge Kagiema - Fay
Serge Kagiema - Fay
2,879 Points
Serge Kagiema - Fay
Serge Kagiema - Fay
2,879 Points

When using floating you must always have in mind about clearing floats. Check this tutorial out : https://www.sitepoint.com/clearing-floats-overview-different-clearfix-methods/

Adam Butcher
seal-mask
.a{fill-rule:evenodd;}techdegree
Adam Butcher
Front End Web Development Techdegree Student 12,180 Points
Adam Butcher
.a{fill-rule:evenodd;}techdegree
Adam Butcher
Front End Web Development Techdegree Student 12,180 Points

Added that line in my wrapper css, and it somehow works. Thanks.

Serge Kagiema - Fay
Serge Kagiema - Fay
2,879 Points

Also add in your css

section:after { visibility: hidden; display: block; font-size: 0; content: " "; clear: both; height: 0; }

and remove

header { -----> float:left; -----> width: 100%

//keep the other properties }

//#wrapper { ----> remove padding-top: 67px; }

This a technique for dealing with floating child elements. the parent must have a pseudo with those properties