Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community!

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Python Basics (2015) Letter Game App Letter Game Introduction

Todd Janisch
Todd Janisch
5,075 Points

When I have guessed the correct amount of letters the game continues instead of printing "You win!..." Please Help!

import random

# make a list of words
words = [

while True: 
    start = input("Press enter/return to start, or Q to quit.")
    if start.lower() == "q":
    # pick a random word from that list
    secret_word = random.choice(words)
    bad_guesses = []
    good_guesses = []

    while len(bad_guesses) < 7 and len(good_guesses) != len(list(secret_word)):
        # draw spaces, guessed letters, and strikes
        for letter in secret_word:
            if letter in good_guesses:
                print(letter, end='')
                print('_', end='')

        print("Strikes: {}/7".format(len(bad_guesses)))

        # take guess
        guess = input("Guess a letter: ").lower()

        if len(guess) != 1:
            print("You can only guess one letter!")
        elif guess in bad_guesses or guess in good_guesses:
            print("You've already guessed that letter!")
        elif not guess.isalpha():
            print("You can only guess letters!")

        if guess in secret_word:
            if len(good_guesses) == len(list(secret_word)):
                print("You win! The word was {}.".format(secret_word))
        # print out win/lose
        print("You didn't  guess it! My secret word was {}.".format(secret_word))

[MOD: added ```python formatting -cf]

2 Answers

Chris Freeman
Chris Freeman
Treehouse Moderator 68,332 Points

If the secret_word has repeated letters, the length of secret_word will always be longer than the length of good_guesses.

How can you change the comparison: len(good_guesses) != len(list(secret_word)) so that only unique characters in the secret_word are counted?

Post back if you need more hints. Good Luck!!

Hope I'm not stealing his thunder but since I was having the same problem...I tried this (replaced "list()" with "set()" and it seemed to work:

if len(good_guesses) == len(set(secret_word)):
                print("You win! The word was {}".format(secret_word))