Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Object-Oriented JavaScript Getters and Setters Creating Setter Methods

Mateusz Dziki
Mateusz Dziki
6,593 Points
Posted by Mateusz Dziki
Mateusz Dziki
6,593 Points

Where is mistake?

I don't understand where is mistake. When i run my code, i see that student.major property is correct.

creating_setters.js 
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }

    set major(major){
      if(major === 'Senior' || major === 'Junior' ){
        this._major = major;
      } else if(major === 'Freshman' || major === 'Sophomore' ){
        this._major = 'None';
      }
    }

    get major() {
      return this._major;
    }

    get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }
}

var student = new Student(3.9, 60);
student.major = student.level;

1 Answer

Steven Parker
Steven Parker
229,786 Points
Steven Parker
Steven Parker
229,786 Points

The instructions say "If the student's level is Junior or Senior...", but this code is testing the argument "major" instead of the level.