Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Selecting Multiple Elements

where is the problem I am not understanding what i am missing

I am not understanding what i am missing

js/app.js
var listItems=document.querySelector('#rainbow');
var colors = ["#C2272D", "#F8931F", "#FFFF01", "#009245", "#0193D9", "#0C04ED", "#612F90"];

for(let i = 0; i < colors.length; i ++) {
  listItems[i].style.color = colors[i];    
}
index.html
<!DOCTYPE html>
<html>
  <head>
    <title>Rainbow!</title>
  </head>
  <body>
    <ul id="rainbow">
      <li>This should be red</li>
      <li>This should be orange</li>
      <li>This should be yellow</li>
      <li>This should be green</li>
      <li>This should be blue</li>
      <li>This should be indigo</li>
      <li>This should be violet</li>
    </ul>
    <script src="js/app.js"></script>
  </body>
</html>

1 Answer

Harald N
Harald N
15,831 Points

What you have done now with the variable listItems:

 var listItems = document.querySelector("#rainbow");

is to target the ul element with the id of rainbow, and not the li elements. This is a quick fix:

var listItems = document.querySelectorAll("#rainbow li");

Now you will be targeting all the li elements inside the ul element with the id of rainbow. Now your var listItems will be an array of all the list items inside #rainbow. This is all the change you will need to do, to make it work.

I hope this solves your problem. If not, ask and I'll try to say it in a different way :D

thanks for your help