Why am I getting test failures when I run bin/rspec spec/features/todo_lists/create_spec.rb?

Question

$ bin/rspec spec/features/todo_lists/create_spec.rb
FF

Failures:

  1) Creating Todo lists redirects to the Todo list index page on success
     Failure/Error: visit "/todo_lists"
     SyntaxError:
       C:/Users/Doesha/desktop/projects/odot/app/models/todo_list.rb:2: syntax error, unexpected tSYMBEG, expecting keyword_do or '{' or '('
        validates :title, presence :true
                                    ^
     # ./app/controllers/todo_lists_controller.rb:7:in `index'
     # ./spec/features/todo_lists/create_spec.rb:5:in `block (2 levels) in <top (required)>'

  2) Creating Todo lists displays an error when the todo list has no title
     Failure/Error: expect(TodoList.count).to eq(0)
     SyntaxError:
       C:/Users/Doesha/desktop/projects/odot/app/models/todo_list.rb:2: syntax error, unexpected tSYMBEG, expecting keyword_do or '{' or '('
        validates :title, presence :true
                                    ^
     # ./spec/features/todo_lists/create_spec.rb:17:in `block (2 levels) in <top (required)>'

Finished in 0.09355 seconds
2 examples, 2 failures

Failed examples:

rspec ./spec/features/todo_lists/create_spec.rb:4 # Creating Todo lists redirects to the Todo list index page on success
rspec ./spec/features/todo_lists/create_spec.rb:16 # Creating Todo lists displays an error when the todo list has no title

Randomized with seed 56798

Answer 1 · 2015-09-20T08:00:08Z

September 20, 2015 8:00am

Can you post you todo_list.rb please.

I think you have:

validates :title, presence :true

It should be

validates :title, presence: true

Move the colon.

Steve.

Answer 2 · 2015-09-20T15:57:44Z

September 20, 2015 3:57pm

Two issues here - both are in create_spec.rb.

The second test is failing due to a typo - your failure says: undefined method `cilck_button' - just correct the spelling.

The first issue is down to the test not correlating to the page. The failures can be really descriptive (they can also be wholly unhelpful!!). This one is OK - it is saying that your test is expecting the page to have the content "New todo_list" but it is finding (correctly in my view) "New Todo List". Your test is wrong, in my opinion.

Change the code in create_spec.rb from:

expect(page).to have_content("New todo_list")

to

expect(page).to have_content("New Todo List")

That reflects what you are trying to test. This may just flush out another failure - that's good; this is how test driven development works.

The bit of the error that explains that is:

expect(page).to have_content("New todo_list") expected to find text "New todo_list" in "New Todo List Title Description Back"

Hope that helps!

Steve.

Answer 3 · 2015-10-12T16:43:34Z

October 12, 2015 4:43pm

Never come across that before but it looks like it makes the console look better and to query the terminal: https://rubygems.org/gems/win32console/versions/1.3.2

I'd put it outside of any groups in the Gemfile. As for using it, I don't know - where have you come across this? What said you need to include it?

Steve.

Answer 4 · 2015-09-20T17:38:37Z

September 20, 2015 5:38pm

Did you also correct the inconsistency between:

click_button "Create Todo lists"

and

click_button "Create Todo list"

as I think that was the cause of the error: Capybara::ElementNotFound: Unable to find button "Create Todo lists" as it was looking for the plural when only the singular existed.

Glad you got on your way.

Steve.

Answer 5 · 2015-09-21T08:35:31Z

September 21, 2015 8:35am

Hi Aaron,

A deprecation is where the functionality you are using has been superceded by something better. The thing you're using still works, which is why you get a warning not an error, but there may be a better way of doing that in the later version of the various chunks of software that make up Ruby on Rails

Unless you're really wanting rid of the warnings, just ignore them. The errors themselves usually give you instructions on how to suppress them Best just ignore, though - don't worry about them.

You have no failures in there - which is one hell of an achievement! This course is a tricky one!

Steve.

Answer 6 · 2015-09-20T15:46:52Z

September 20, 2015 3:46pm

I changed my todo list around to the second part of your answer, but I'm still getting test failures. I am on a Windows 10 OS so that might be the problem! Here's my todo_list.rb file:

class TodoList < ActiveRecord::Base
    validates :title, presence: true
end

I'm still getting the same results which is a failed test. Here is my output:

$ bin/rspec spec/features/todo_lists/create_spec.rb
FF

Failures:

  1) Creating Todo lists displays an error when the todo list has no title
     Failure/Error: expect(page).to have_content("New todo_list")
       expected to find text "New todo_list" in "New Todo List Title Description Back"
     # ./spec/features/todo_lists/create_spec.rb:21:in `block (2 levels) in <top (required)>'

  2) Creating Todo lists redirects to the Todo list index page on success
     Failure/Error: cilck_button "Create Todo lists"
     NoMethodError:
       undefined method `cilck_button' for #<RSpec::Core::ExampleGroup::Nested_1:0x742f620>
     # ./spec/features/todo_lists/create_spec.rb:11:in `block (2 levels) in <top (required)>'

Finished in 1.29 seconds
2 examples, 2 failures

Failed examples:

rspec ./spec/features/todo_lists/create_spec.rb:16 # Creating Todo lists displays an error when the todo list has no title
rspec ./spec/features/todo_lists/create_spec.rb:4 # Creating Todo lists redirects to the Todo list index page on success

Randomized with seed 744

Any idea what could be the reason I'm having a result of failing test?

Answer 7 · 2015-09-20T16:31:58Z

September 20, 2015 4:31pm

Hey Steve,

I've gotten rid of one failed test and I appreciate your help with that one; but I'm still getting another failed test. I'm assuming this is the test you stated that would fail previously in your response answers above.

Here is the output from the failed test I've just gotten:

$ bin/rspec spec/features/todo_lists/create_spec.rb
F.

Failures:

  1) Creating Todo lists redirects to the Todo list index page on success
     Failure/Error: click_button "Create Todo lists"
     Capybara::ElementNotFound:
       Unable to find button "Create Todo lists"
     # ./spec/features/todo_lists/create_spec.rb:11:in `block (2 levels) in <top (required)>'

Finished in 0.8416 seconds
2 examples, 1 failure

Failed examples:

rspec ./spec/features/todo_lists/create_spec.rb:4 # Creating Todo lists redirects to the Todo list index page on success

Randomized with seed 37526

Is this something involving the Capybara gem not being up-to-date? Could it be another syntax error somewhere?

Here's my create_spec.rb file:

require 'spec_helper'

describe "Creating Todo lists" do 
    it "redirects to the Todo list index page on success" do
        visit "/todo_lists"
        click_link "New Todo list"
        expect(page).to have_content("New Todo List")

        fill_in "Title", with: "My todo list"
        fill_in "Description", with: "This is what I'm doing today."
        click_button "Create Todo lists"

        expect(page).to have_content("My todo List")
    end

    it "displays an error when the todo list has no title" do
        expect(TodoList.count).to eq(0)

        visit "/todo_lists"
        click_link "New Todo list"
        expect(page).to have_content("New Todo List")

        fill_in "Title", with: ""
        fill_in "Description", with: "This is what I'm doing today."
        click_button "Create Todo list"

        expect(page).to have_content("error")
        expect(TodoList.count).to eq(0)

        visit "/todo_lists"
        expect(page).to_not have_content("This is what I'm doing today.")
    end 
end

Answer 8 · 2015-09-20T16:58:45Z

September 20, 2015 4:58pm

Hey Steve,

I found the problem!

My test code

expect(page).to have_content("My todo List")

and

fill_in "Title", with: "My todo list"

wasn't consistent in their syntax.

I just had to make sure everything matched up like you stated before.

Thanks for your help!

Aaron

Answer 9 · 2015-09-20T21:48:07Z

September 20, 2015 9:48pm

Yes, I did correct the inconsistency between

click_button "Create Todo lists"

and

click_button "Create Todo list"

I'll definitely give you a shout out if I run across any more problems!

Answer 10 · 2015-09-20T22:46:10Z

September 20, 2015 10:46pm

Hey Steve,

I just ran the command

bin/rake spec

and it's saying that I have Deprecation Warnings. What are Deprecation's and how can I get rid of them?

Here's the output I got:

..*.*....................DEPRECATION WARNING: `named_routes.helpers` is deprecated, please use `route_defined?(route_name)` to see if a named route was defined. (called from block (4 levels) in <top (required)> at C:/Users/Doesha/desktop/projects/odot/spec/controllers/todo_lists_controller_spec.rb:75)
.....DEPRECATION WARNING: `named_routes.helpers` is deprecated, please use `route_defined?(route_name)` to see if a named route was defined. (called from block (3 levels) in <top (required)> at C:/Users/Doesha/desktop/projects/odot/spec/controllers/todo_lists_controller_spec.rb:156)
..

Pending:
  TodoListsHelper add some examples to (or delete) C:/Users/Doesha/desktop/projects/odot/spec/helpers/todo_lists_helper_spec.rb
    # No reason given
    # ./spec/helpers/todo_lists_helper_spec.rb:14
  TodoList add some examples to (or delete) C:/Users/Doesha/desktop/projects/odot/spec/models/todo_list_spec.rb
    # No reason given
    # ./spec/models/todo_list_spec.rb:4

Deprecation Warnings:

--------------------------------------------------------------------------------
The semantics of `RSpec::Core::ExampleGroup.pending` are changing in RSpec 3.
In RSpec 2.x, it caused the example to be skipped. In RSpec 3, the example will
still be run but is expected to fail, and will be marked as a failure (rather
than as pending) if the example passes, just like how `pending` with a block
from within an example already works.

To keep the same skip semantics, change `pending` to `skip`.  Otherwise, if you
want the new RSpec 3 behavior, you can safely ignore this warning and continue
to upgrade to RSpec 3 without addressing it.

Called from C:/Users/Doesha/desktop/projects/odot/spec/helpers/todo_lists_helper_spec.rb:14:in `block in <top (required)>'.

--------------------------------------------------------------------------------
--------------------------------------------------------------------------------
The semantics of `RSpec::Core::ExampleGroup.pending` are changing in RSpec 3.
In RSpec 2.x, it caused the example to be skipped. In RSpec 3, the example will
still be run but is expected to fail, and will be marked as a failure (rather
than as pending) if the example passes, just like how `pending` with a block
from within an example already works.

To keep the same skip semantics, change `pending` to `skip`.  Otherwise, if you
want the new RSpec 3 behavior, you can safely ignore this warning and continue
to upgrade to RSpec 3 without addressing it.

Called from C:/Users/Doesha/desktop/projects/odot/spec/models/todo_list_spec.rb:4:in `block in <top (required)>'.

--------------------------------------------------------------------------------

`stub_model` is deprecated. Use the `rspec-activemodel-mocks` gem instead. Called from C:/Users/Doesha/desktop/projects/odot/spec/views/todo_lists/index.html.erb_spec.rb:6:in `block (2 levels) in <top (required)>'.
`stub_model` is deprecated. Use the `rspec-activemodel-mocks` gem instead. Called from C:/Users/Doesha/desktop/projects/odot/spec/views/todo_lists/index.html.erb_spec.rb:10:in `block (2 levels) in <top (required)>'.
`stub_model` is deprecated. Use the `rspec-activemodel-mocks` gem instead. Called from C:/Users/Doesha/desktop/projects/odot/spec/views/todo_lists/new.html.erb_spec.rb:5:in `block (2 levels) in <top (required)>'.
Too many uses of deprecated '`stub_model`'. Pass `--deprecation-out` or set `config.deprecation_stream` to a file for full output.


If you need more of the backtrace for any of these deprecations to
identify where to make the necessary changes, you can configure
`config.raise_errors_for_deprecations!`, and it will turn the
deprecation warnings into errors, giving you the full backtrace.

7 deprecation warnings total

Finished in 3.57 seconds
32 examples, 0 failures, 2 pending

Randomized with seed 35934

C:/RailsInstaller/Ruby2.1.0/bin/ruby.exe -S rspec ./spec/controllers/todo_lists_controller_spec.rb ./spec/features/todo_lists/create_spec.rb ./spec/helpers/todo_lists_helper_spec.rb ./spec/models/todo_list_spec.rb ./spec/requests/todo_lists_spec.rb ./spec/routing/todo_lists_routing_spec.rb ./spec/views/todo_lists/edit.html.erb_spec.rb ./spec/views/todo_lists/index.html.erb_spec.rb ./spec/views/todo_lists/new.html.erb_spec.rb ./spec/views/todo_lists/show.html.erb_spec.rb

Answer 11 · 2015-10-12T16:34:22Z

October 12, 2015 4:34pm

Hey Steve,

Thanks for clearing up that deprecation thing for me, I really appreciate that!

I did have another question though; can you tell me what this means:

ansi: 'gem install win32console' to use color on Windows

I'm assuming that this gem is needed somewhere in my gem file to help me get color on my command line. I'm not sure about how to use it or where exactly should I put it in my gem file though.

Answer 12 · 2015-10-13T18:04:30Z

October 13, 2015 6:04pm

Well, it was demonstrated by Michael Hartl in the screencast videos, so that maybe why you probably didn't come across it when you were reading the book.

Answer 13 · 2015-10-15T17:40:55Z

October 15, 2015 5:40pm

Yes, they are very good and definitely worth the watch! Gives you a lot of clarification on different ways and techniques you can use that can't be explained and understood clearly to the average beginner through text. In my opinion, they're the best tutorial videos I've seen so far!

Answer 14 · 2015-10-20T15:23:34Z

October 20, 2015 3:23pm

Hey Steve,

I'm trying to add a feature to my rails project where users can upload an audio file. To do that, should I create a new model for the audio files or can I just add to an existing model I already have? I have my app set up already where a user can upload an image, but I'm not to sure how I can have the user upload an audio file also.

Do you think you can help me out with that? I have my code up on Github also if you would like to check it out!

Answer 15 · 2015-10-24T17:04:21Z

October 24, 2015 5:04pm

Okay, thanks Steve! That actually makes a lot of sense to make a separate model instead of adding onto an existing model. Thanks for giving me a clearer understanding!

Answer 16 · 2015-10-20T15:32:02Z

October 20, 2015 3:32pm

Difficult to answer that - what is the app? Do you have it running in Heroku, for example?

A Model should be introduced for something new and distinct. It's almost like a class in Java, for example.

So, a User has a model. If you remember in the Todo list app, each todo item was a model and each todo list was a model. They are distinct things in that usage.

What will the audio file be doing in your app?

I don't think it would ever be wrong to create a new model for this - it might not be wholly efficient - but I'd say you can develop the functionality more easily if it were a separate model, rather than expanding the existing model to cope with audio-only requirements, if that makes sense?

Hope that helps but I suspect you're better at Rails than I am!!

Steve.

Answer 17 · 2015-10-27T18:59:22Z

October 27, 2015 6:59pm

Hello Steve,

How can I delete a migration file by the migration id number? I don't really understand the rollback migration command to well and the migration file I want to delete wasn't my last migration created. It was created a couple migrations before my last migration.

Thanks,

Aaron

Welcome to the Treehouse Community

Looking to learn something new?

Aaron Butler

Aaron Butler

Why am I getting test failures when I run bin/rspec spec/features/todo_lists/create_spec.rb?

17 Answers

Steve Hunter

Steve Hunter

Steve Hunter

Steve Hunter

Steve Hunter

Steve Hunter

Aaron Butler

Aaron Butler

Steve Hunter

Steve Hunter

Steve Hunter

Steve Hunter

Steve Hunter

Steve Hunter

Aaron Butler

Aaron Butler

Steve Hunter

Steve Hunter

Aaron Butler

Aaron Butler

Steve Hunter

Steve Hunter

Aaron Butler

Aaron Butler

Steve Hunter

Steve Hunter

Aaron Butler

Aaron Butler

Aaron Butler

Aaron Butler

Aaron Butler

Aaron Butler

Aaron Butler

Aaron Butler

Steve Hunter

Steve Hunter

Aaron Butler

Aaron Butler

Aaron Butler

Aaron Butler

Aaron Butler

Aaron Butler

Steve Hunter

Steve Hunter

Aaron Butler

Aaron Butler

Steve Hunter

Steve Hunter