JavaScript JavaScript and the DOM Getting a Handle on the DOM Practice Selecting Elements

Sunny Balani
Sunny Balani
6,615 Points

Why does document.querySelectorAll('nav ul'); not work

it keeps saying i only selected one link

let navigationLinks = document.querySelectorAll('header nav');
let galleryLinks;
let footerImages;
<!DOCTYPE html>
    <meta charset="utf-8">
    <title>Nick Pettit | Designer</title>
    <link rel="stylesheet" href="css/normalize.css">
    <link href='|Open+Sans:400italic,700italic,400,700,800' rel='stylesheet' type='text/css'>
    <link rel="stylesheet" href="css/main.css">
    <link rel="stylesheet" href="css/responsive.css">
    <meta name="viewport" content="width=device-width, initial-scale=1.0">
      <a href="index.html" id="logo">
        <h1>Nick Pettit</h1>
          <li><a href="index.html" class="selected">Portfolio</a></li>
          <li><a href="about.html">About</a></li>
          <li><a href="contact.html">Contact</a></li>
    <div id="wrapper">
        <ul id="gallery">
            <a href="img/numbers-01.jpg">
              <img src="img/numbers-01.jpg" alt="">
              <p>Experimentation with color and texture.</p>
            <a href="img/numbers-02.jpg">
              <img src="img/numbers-02.jpg" alt="">
              <p>Playing with blending modes in Photoshop.</p>
        <a href=""><img src="img/twitter-wrap.png" alt="Twitter Logo" class="social-icon"></a>
        <a href=""><img src="img/facebook-wrap.png" alt="Facebook Logo" class="social-icon"></a>
        <p>&copy; 2016 Nick Pettit.</p>
  <script src="js/app.js"></script>

1 Answer

Dane Parchment
Dane Parchment
Treehouse Moderator 9,663 Points

Your code is actually doing exactly what it is supposed to do.

let navigationLinks = document.querySelectorAll('header nav');

There is only one element that is a descendent of header and is a nav. However, you are also targeting the wrong thing. We are looking to get all of the links that can be found under any nav.

So what does that mean? We need to get every link that can be found under any nav. So that means we need to find all the a tags that are descendants of a nav tag.

So it should look like this:

let navigationLinks = document.querySelectorAll('nav a');