Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

Python Python Basics (2015) Number Game App String length

Posted by Bryan Morilon
Bryan Morilon
7,492 Points

why doesn't this work?

def just_right(string):

length = int(len(string)) if length > 5: return print("Your string is too short") elif length < 5: return print ("Your string is too long") return True

strlen.py 
def just_right(string):

  length = int(len(string))
  if length > 5:
    return print("Your string is too short")
  elif length < 5:
    return print ("Your string is too long")
  return True

1 Answer

Jason Anello
Jason Anello
Courses Plus Student 94,610 Points

Hi Bryan,

The length of a string will already be an integer so you don't have to convert it to int

You should only return the strings, not print them and return.

You might have your strings swapped too looking at the logic. If the length is greater than 5 then the string should be too long, not too short.

Bryan Morilon
Bryan Morilon
7,492 Points

thank you for your help. After reading your answer I changed it to;

def just_right(string):

  length = len(string)
  if length < 5:
    return "Your string is too short"
  elif length > 5:
    return "Your string is too long"
  return True

and it passed the code challenge.