Python Object-Oriented Python Dice Roller RPG Roller

Luke Annison
Luke Annison
7,462 Points

Why doesn't this work?

Hi guys,

Could someone please tell me why my code doesn't work/solve the challenge?

Many thanks

dice.py
import random


class Die:
    def __init__(self, sides=2):
        if sides < 2:
            raise ValueError("Can't have fewer than two sides")
        self.sides = sides
        self.value = random.randint(1, sides)

    def __int__(self):
        return self.value

    def __add__(self, other):
        return int(self) + other

    def __radd__(self, other):
        return self + other

class D20(Die):
    def __init__(self):
        super().__init__(sides=20)
hands.py
class Hand(list):
    @property
    def total(self):
        return sum(self)

    def roll(cls, diceNo):
        hand = Hand()
        for _ in range(diceNo):
            self.append(D20())
        return hand

4 Answers

Chris Freeman
MOD
Chris Freeman
Treehouse Moderator 64,074 Points

Sorry, I missed the syntax error in the import statement. The format should be:

from module import object

So,

from dice import D20

Also, the correct posting formatting uses backticks: ```python. you have been using three single quotation marks.

The backtick is in the upper left of keyboard near the 1 key.

Post back if you need more help. Good luck!!!

Chris Freeman
MOD
Chris Freeman
Treehouse Moderator 64,074 Points

You are very close!!

  • need to import D20 from dice
  • add @classmethod to roll method
  • reference the current class as cls() instead of Hand

Post back if you need more help. Good luck!!!

Luke Annison
Luke Annison
7,462 Points

Hey! Thanks! Tried this but not quite there yet:

import D20 from dice

class Hand(list):
    @property
    def total(self):
        return sum(self)

    @classmethod
    def roll(cls, diceNo):
        hand = cls()
        for _ in range(diceNo):
            self.append(D20())
        return hand
Chris Freeman
Chris Freeman
Treehouse Moderator 64,074 Points

self is not defined in the roll method. You have defined the new object name as hand, so it should be hand.append

Luke Annison
Luke Annison
7,462 Points

Hi Chris,

Thanks, but sorry it still doesn't quite work for me! Could you please take hopefully a final look:

import D20 from dice

class Hand(list):
    @property
    def total(self):
        return sum(self)

    @classmethod
    def roll(cls, diceNo):
        hand = cls()
        for _ in range(diceNo):
            hand.append(D20())
        return hand