Why is my disemvowel not working?

Question

I'm trying a very simple approach. I wonder why this won't work as planned..
@Chris Freeman (https://teamtreehouse.com/chrisfreeman3) 
disemvowel.py
vowels = ["a","e", "i", "o", "u", "A", "E", "I", "O", "U"]
def disemvowel(word):
    list(word)
    if vowels in word:
        word.remove(vowels)
    else:
        pass
    return word

Mark Rinkel · Accepted Answer

This line
python
if vowels in word:

is actually asking this:
python
if ["a","e", "i", "o", "u", "A", "E", "I", "O", "U"] in word:

You instead want to check each letter to see if it's in the word.

Chris Freeman · Answer

I've marked up your code with the errors
Python
vowels = ["a","e", "i", "o", "u", "A", "E", "I", "O", "U"]
def disemvowel(word):
    word = list(word)  # list result needs to be assigned 
    # need loop to iterate over a *copy* of word
    for letter in word.copy():
        if letter in vowels: # reverse comparison 
            word.remove(letter)
        #else:  # empty else can be omitted 
         #   pass
    # need to join list back to string 
    word = "".join(word)
    return word

Ari Misha · Answer

Hiya Marie! You need to think it logically, so yeah try it this way: 
  "for every word in words,"
     "if not word exists in vowels"
         "append word to an empty list"
  "and finally return the list"
I couldnt have come up with a better hint so yeah try it this way. (:

Welcome to the Treehouse Community

Looking to learn something new?

Marie Lu

Marie Lu

Why is my disemvowel not working?

3 Answers

Mark Rinkel

Mark Rinkel

Ari Misha

Ari Misha

Chris Freeman

Chris Freeman