Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Traversing the DOM Solution: Using nextElementSibling

Marcell Ciszek
Marcell Ciszek
7,255 Points
Posted by Marcell Ciszek
Marcell Ciszek
7,255 Points

Why is my down button not working?

I cant fix it

const toggleList = document.getElementById('toggleList'); const listDiv = document.querySelector('.list'); const descriptionInput = document.querySelector('input.description'); const descriptionP = document.querySelector('p.description'); const descriptionButton = document.querySelector('button.description'); const listUl = listDiv.querySelector('ul'); const addItemInput = document.querySelector('input.addItemInput'); const addItemButton = document.querySelector('button.addItemButton');

listUl.addEventListener('click', (event) => { if (event.target.tagName == 'BUTTON') { if (event.target.className == 'remove') { let li = event.target.parentNode; let ul = li.parentNode; ul.removeChild(li); } if (event.target.className == 'up') { let li = event.target.parentNode; let prevLi = li.previousElementSibling; let ul = li.parentNode; if (prevLi) { ul.insertBefore(li, prevLi); } } if (event.target.className === 'down'){ let li = event.target.parentNode; let nextLi = li.nextElementSibling; let ul = li.parentNode; if(nextLi){ ul.insertBefore(li,nextLi); } } } });

1 Answer

KRIS NIKOLAISEN
KRIS NIKOLAISEN
54,972 Points
KRIS NIKOLAISEN
KRIS NIKOLAISEN
54,972 Points

You have nextLi and li reversed in insertBefore here:

 if (event.target.className == 'down'){
            let li = event.target.parentNode;
            let nextLi = li.nextElementSibling;
            let ul = li.parentNode;
            if(nextLi){ 
                ul.insertBefore(li,nextLi); //<--------reversed
            }
        }

It should be 

 ul.insertBefore(nextLi, li);
Marcell Ciszek
Marcell Ciszek
7,255 Points
Marcell Ciszek
Marcell Ciszek
7,255 Points

Thank you for the answer