Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

JavaScript React Basics (retired) Thinking in Components Decomposing our Application

Jason Welsh
seal-mask
.a{fill-rule:evenodd;}techdegree seal-36
Jason Welsh
Treehouse Project Reviewer

Why is my layout breaking here?

I think I followed every step exactly but my players components are breaking outside of their container. Here is my code so far:

function Header(props) {
  return (
    <div className="header">
      <h1>{props.title}</h1>
    </div>
  );
}

Header.propTypes = {
  title: React.PropTypes.string.isRequired, 
};

function Player(props) {
  return (
   <div className="player">
      <div className="player-name">
        {props.name}
      </div>
      <div className="player-score">
        <div className="counter">
          <button className="counter-action decrement"> - </button>
          <div className="counter-score"> props.score </div>
          <button className="counter-action increment"> + </button>
        </div>
      </div>
    </div>
  );
}

Player.propTypes = {
  name: React.PropTypes.string.isRequired,
  score: React.PropTypes.number.isRequired,
}

function Application(props) {
  return (
   <div className="scoreboard">

    <Header title={props.title} />

    <div className="players">

      <Player name="Jason Welsh" score={99} />
      <Player name="Athena Welsh" score={99} />

    </div>

   </div>
  );
}

Application.propTypes = {
  title: React.PropTypes.string, 
};

Application.defaultProps = {
  title: "Scoreboard",
};

ReactDOM.render(<Application />, document.getElementById('container'));

1 Answer

In your Player function, you need to wrap props.score with {}. so it should be

<div className="counter-score"> {props.score}</div>

You also need to refactor it to a Counter function, which is done later in the video.