Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Basics (Retired) Making Decisions with Conditional Statements Improving the Random Number Guessing Game

Sufiyaan Haroon
seal-mask
.a{fill-rule:evenodd;}techdegree
Sufiyaan Haroon
Full Stack JavaScript Techdegree Student 9,558 Points

Why is saying wrong?

I did all the code right but when I get the number correct in the second try it still says that: Sorry. The number was 4. or any other number

var correctGuess = false; var randomNumber = Math.floor(Math.random() * 6 ) + 1; var guess = prompt('I am thinking of a number between 1 and 6. What is it?'); if (parseInt(guess) === randomNumber ) { correctGuess = true; } if ( correctGuess ) { document.write('<p>You guessed the number!</p>'); } else { document.write('<p>Sorry. The number was ' + randomNumber + '.</p>'); } if ( parseInt(guessMore) === randomNumber ) { correctGuess = true; } else if (parseInt(guess) < randomNumber) { var guessMore = prompt("Try again. The number I am thinking is more than " + guess); }

else if (parseInt(guess) > randomNumber) { var guessLess = prompt("Try again. The number I am thinking of is less than " + guess); } if (parseInt(guessLess) === randomNumber) { correctGuess = true; }

Steven Parker
Steven Parker
229,921 Points

When posting code, always use the instructions for code formatting in the Markdown Cheatsheet pop-up below the "Add an Answer" area. :arrow_heading_down: Or watch this video on code formatting.

1 Answer

Steven Parker
Steven Parker
229,921 Points

It looks like things are a bit out of order.

It's tough working with unformatted code, but I managed to spot a few issues anyway:

  • if the first guess is not correct, you immediately reveal the answer
  • after the first guess, you parse and test "guessMore", but that variable has not yet been created
  • only if that test fails do you ask for a second input and set either "guessMore" or "guessLess"
  • then, without checking to see which was used, you parse and test "guessLess"
  • but after that, the program ends without doing anything with the result of the last test

So you probably want to move things around, keeping in mind:

  • ask questions and get responses before testing the responses
  • ask all questions before revealing the answer