Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript and the DOM (Retiring) Getting a Handle on the DOM Selecting Multiple Elements

Tauan Flores
seal-mask
.a{fill-rule:evenodd;}techdegree
Tauan Flores
Front End Web Development Techdegree Student 5,277 Points
Posted by Tauan Flores
.a{fill-rule:evenodd;}techdegree
Tauan Flores
Front End Web Development Techdegree Student 5,277 Points

Why is this incorrect? let listItems = document.querySelectorAll('#rainbow');

Why is this incorrect? let listItems = document.querySelectorAll('#rainbow');

index.html 
<!DOCTYPE html>
<html>
  <head>
    <title>Rainbow!</title>
  </head>
  <body>
    <ul id="rainbow">
      <li>This should be red</li>
      <li>This should be orange</li>
      <li>This should be yellow</li>
      <li>This should be green</li>
      <li>This should be blue</li>
      <li>This should be indigo</li>
      <li>This should be violet</li>
    </ul>
    <script src="js/app.js"></script>
  </body>
</html>
js/app.js 
let listItems = document.querySelectorAll('#rainbow');
const colors = ["#C2272D", "#F8931F", "#FFFF01", "#009245", "#0193D9", "#0C04ED", "#612F90"];

for(var i = 0; i < colors.length; i+=1) {
  listItems[i].style.color = colors[i];    
}

1 Answer

Spencer Bigum
Spencer Bigum
3,250 Points
Spencer Bigum
Spencer Bigum
3,250 Points

you're only selecting the main UL element. You need to target the children of it.

let listItems = document.querySelectorAll('#rainbow')[0].children;
Damjan Bozinovski
Damjan Bozinovski
9,916 Points

This is inappropriate because you use CSS selector when there is no CSS involved here and the course doesn't cover the .children tag so far.