Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript JavaScript Loops, Arrays and Objects Simplify Repetitive Tasks with Loops Create a `do...while` loop

Posted by Chikanma Ibeh
Chikanma Ibeh
1,396 Points

Why is this wrong?

var secret = prompt("What is the secret password?"); do { secret = prompt("What is the secret password?"); } while ( secret !== "sesame" ) document.write("You know the secret password. Welcome.");

script.js 
var secret = prompt("What is the secret password?");
do { 
  secret = prompt("What is the secret password?");
} while ( secret !== "sesame" )
document.write("You know the secret password. Welcome.");
index.html 
<!DOCTYPE html>
<html>
<head>
  <meta charset="utf-8">
  <title>JavaScript Loops</title>
</head>
<body>
<script src="script.js"></script>
</body>
</html>

1 Answer

Ben Slivinn
Ben Slivinn
10,156 Points
Ben Slivinn
Ben Slivinn
10,156 Points

Do while will actually loop at least one time and then check the condition, so the deceleration of "var secret" at the beginning is unnecessary. You should declare the variable inside 'do {}'

<script>
do { var secret = prompt("What is the secret password?"); }
while ( secret !== "sesame" ) document.write("You know the secret password. Welcome.");
</script>

Better practice is to have a variable for the secret word and one for the anawer, and then compare them in the loop condition.

Cheers!