Why isn't my code working

Question

This question is from Teacher Stats task 4 out of 4 from Python Collections
I keep on getting the error 'Bummer! You returned 5 courses, you should have returned 18
can someone help me?
The dictionary will be something like:
teachers = {'Jason Seifer': ['Ruby Foundations', 'Ruby on Rails Forms', 'Technology Foundations'],
            'Kenneth Love': ['Python Basics', 'Python Collections']}
Often, it's a good idea to hold onto a max_count variable.
Update it when you find a teacher with more classes than
the current count. Better hold onto the teacher name somewhere
too!
Your code goes below here.
def mostclasses(teachers):
    maxcount = 0;
    teacher = ""
    for key in teachers: 
        count = len(teachers[key])
        if count > maxcount:
            teacher = key
            maxcount = count
    return teacher
def num_teachers(teachers):
    count = 0
    for key in teachers:
        count += 1
    return count
def stats(teachers):
    statslist = []
    teacher = ""
    for key in teachers:
        teacher = key
        count = len(teachers[key])
        statslist.extend([[teacher, count]])
    return stats_list
def courses(teachers):
    courses = []
    for value in teachers.values():
        courses.append(value)
    return courses

Aby Abraham · Answer

```Python
def courses(dict):
    clist = []
    for value in dict.values():
        clist.extend(value)
    return clist
```

Steven Parker · Answer

I think I've spotted your problem despite the formatting issue...
:point_right: It looks like you're collecting lists instead of individual courses.
The dictionary values are lists of courses, so if you append a value you're adding the entire list as a single item.
To add the items, use extend rather than append, or concatenate the list with +=.

Welcome to the Treehouse Community

Looking to learn something new?

Jade Jupiter

Jade Jupiter

Why isn't my code working

The dictionary will be something like:

Often, it's a good idea to hold onto a max_count variable.

Update it when you find a teacher with more classes than

the current count. Better hold onto the teacher name somewhere

too!

Your code goes below here.

Steven Parker

Steven Parker

It's VERY hard to read Python without proper code formatting.

2 Answers

Steven Parker

Steven Parker

It looks like you're collecting lists instead of individual courses.

Aby Abraham

Aby Abraham