Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

JavaScript Build a Simple Dynamic Site with Node.js Creating a Basic Template Engine in Node.js A Simple Merge Utility

Ajithlal Parackel
Ajithlal Parackel
990 Points

why it is off

Why it is not getting result

index.js
var utilities = require("./utilities");

var mailValues = {};

mailValues.first_name = "Janet";

var emailTemplate = "Hi %first_name%! Thanks for completing this code challenge :)";

var mergedContent = utilities.merge(emailTemplate, mailValues);

//mergedContent === "Hi Janet! Thanks for completing this code challenge :)";
utilities.js
function merge(content, values) {
  for (var key in values) {
    content.replace("%"+key+"%", values[key]);
  }
  return content;
}


module.exports.merge = merge;

1 Answer

Umesh Ravji
Umesh Ravji
42,362 Points

Hi Ajithlal, the replace() method doesn't change the string it's called on, but returns a new string value that must be re-assigned to the value of content in order to save the changes made.

content = content.replace("%"+key+"%", values[key]);