Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript

Hoang Le
PLUS
Hoang Le
Courses Plus Student 1,274 Points

why my code is not working

var html = '';
var rgbColor;
function randomNumber() {
    return Math.floor(Math.random() * 256);
}
function randomColor() {
    var color = "rgb(";
    color += randomNumber + ",";
    color += randomNumber + ",";
    color += randomNumber + ")";
    return color;
}
function print(message) {
    document.write(message);
}
for (var i = 1; i < 50; i ++ )   
{
 rgbColor = randomColor();
html += '<div style="background-color:' + rgbColor + '"></div>';

}
print(html);

I don't why it is not working....

In the function randomColor when you call randomNumber ... the random number is a function not a variable .

function randomColor() { var color = "rgb("; color += randomNumber() + ","; color += randomNumber() + ","; color += randomNumber() + ")"; return color; }

1 Answer

Steven Parker
Steven Parker
229,018 Points

You named the function instead of invoking it.

In randomColor, when you call your randomNumber function, you forgot the parentheses after the function name:

  color += randomNumber + ",";    // <-- this only NAMES the function
  color += randomNumber() + ",";  // <-- this correctly CALLS the function