would this answer also work?

Question

Hi, 
I am doing the 
 JavaScript JavaScript Basics Creating Reusable Code with Functions  Random Number Challenge, Part II
would this solution also be correct? ( I am not checking if the arguments are number I know)
thanks a lot :) 
function calculus (lowerNumber, higherNumber){
var result = Math.floor(Math.random() * (higherNumber)) + 1; 
  if (result > lowerNumber){
  alert("the number is" + result);
} else {
var minresult = result + lowerNumber;
  alert("the number is" + minresult);
}
}
console.log(calculus(100 , 200));

Steven Parker · Answer

For your convenience, I'll repeat my answer to your previous post of this same question (https://teamtreehouse.com/community/would-this-answer-work):
This code will produce numbers outside the range.
Try calling it with  a narrow range of larger numbers, like: calculus(950, 999) a few times and see.  Plus even if it was modified to constrain the answers to the range, the distribution would be uneven.

rydavim · Answer

Please see @Steven Parker (https://teamtreehouse.com/stevenparker) 's answer over here (https://teamtreehouse.com/community/would-this-answer-work).

Robert Stefanic · Answer

Yeah it works. It's a little bit of a round-about way to get a random number between 100 and 200.
It would generally just be easier to put them in one argument though. 
Also, as quick note, by the way you're calling your function in a console.log statement, it's better to have it return something. Right now if you were to run your function, it would display everything as an alert box, rather than having it return a value in your console.log call. So you'll get an undefined in your console, and it's not really doing anything.
So you could either just call your function:
JS
calculus(100, 200);

Or just remove the alerts, and have them return values so that your console.log call to your function returns a value.
Best of luck. :)

Welcome to the Treehouse Community

Looking to learn something new?

adrien kovanic

adrien kovanic

would this answer also work?

3 Answers

Robert Stefanic

Robert Stefanic

rydavim

rydavim

Steven Parker

Steven Parker

This code will produce numbers outside the range.