Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

Python Python Basics (2015) Letter Game App Even or Odd Loop

Naya Willis
Naya Willis
2,461 Points

Wrong code, what am I doing wrong

import random

def even_odd(num): # If % 2 is 0, the number is even. # Since 0 is falsey, we have to invert it with not. return not num % 2

start = 5

while start > 0: rand = random.randint(1,99) if even_odd(rand): print("{} is even".format(rand)) else: print("{} is odd".format(rand)) start -= 1

even.py
import random

def even_odd(num):
    # If % 2 is 0, the number is even.
    # Since 0 is falsey, we have to invert it with not.
    return not num % 2

start = 5

while start > 0:
    rand = random.randint(1,99)
    if even_odd(rand):
        print("{} is even".format(rand))
    else:
        print("{} is odd".format(rand))
        start -= 1

2 Answers

Umesh Ravji
Umesh Ravji
42,361 Points

Hi Naya, you have indented start -= 1 too much, and placed it inside the else block, this means that start will only be decremented if rand is odd. Simply un-indent this part so it runs each time through the while loop.

while start > 0:
    rand = random.randint(1,99)
    if even_odd(rand):
        print("{} is even".format(rand))
    else:
        print("{} is odd".format(rand))
    start -= 1
Naya Willis
Naya Willis
2,461 Points

thanks so much Umesh. Good looking out