Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Object-Oriented JavaScript Getters and Setters Creating Setter Methods

Posted by Paul Harvey
Paul Harvey
17,321 Points

Your setter method is returning the wrong value for the major property.

Perhaps the instructions are unclear on the Creating Setter Methods Challenge Task 2 of 2, or perhaps I haven't been paying close enough attention as to grasp this concept yet, but I'm plain and simply stuck.

Can anyone point me in the right direction?

creating_setters.js 
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }

    get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }
  set major(major){
  this._major = major;
  if (this.credits > 30){
    this._major="None";
    }
  }
}

var student = new Student(3.9, 60);

2 Answers

Jennifer Nordell
seal-mask
STAFF
.a{fill-rule:evenodd;}techdegree
Jennifer Nordell
Treehouse Teacher
Jennifer Nordell
.a{fill-rule:evenodd;}techdegree
Jennifer Nordell
Treehouse Teacher

Hi there, Paul Harvey ! Personally, I think you're doing terrific! You have, however, reversed the logic a bit here :smiley: Your code sets the major to "None" for sophomores, juniors and seniors. With your logic there, only freshman get to have a major which is a bit bizarre for any college/university.

The challenge wants only juniors and seniors to have majors and not freshmen or sophomores. The root of your problem is in your conditional. There are a couple of ways to do this.

You could check to see if the level is either "Freshman" or "Sophomore":

if (this.level == "Freshman" || this.level == "Sophomore")

Alternatively, you could see if their credits are less than or equal to 60 :smiley:

Hope this helps! :sparkles:

Paul Harvey
Paul Harvey
17,321 Points
Paul Harvey
Paul Harvey
17,321 Points

Many thanks! Glad to know I was close, but your steps helped me finish the challenge. :)