JavaScript Object-Oriented JavaScript Getters and Setters Creating Setter Methods

William Mead
William Mead
2,996 Points

Your setter method is returning the wrong value for the major property

When I put this same code into the workspace, it seems to work and provide me with the correct value (simply copied and pasted). However, in the challenge editor it does not seem to be letting it through.

creating_setters.js
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }

    get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }

    get major(){
      return this._major;
    }

    set major(major){

      //this._major = major;

      if( major === 'Junior' || major === 'Senior' ){
        this._major = major;
      }
      else{
        this._major = 'None';
      }

    }
}

var student = new Student(3.9, 60);

student.major = student.level;

3 Answers

KRIS NIKOLAISEN
PRO
KRIS NIKOLAISEN
Pro Student 51,941 Points

Senior, Junior, Sophomore and Freshman are levels not majors. You should be checking this.level to set the major.

William Mead
William Mead
2,996 Points

This response still makes no sense to me. I think part of my frustration is with the instructions...

Inside the major() setter method, set the student's major to a backing property "_major". If the student's level is Junior or Senior, the value of the backing property should be equal to the parameter passed to the setter method. If the student is only a Freshman or Sophomore, set the "_major" backing property equal to 'None'.

so shouldn't the major be set to none since the student is a sophomore based on the number of credits completed? Usually a major is something like "English or Math or Computer Science or Art" but that does not seem to be what the directions are asking for.

KRIS NIKOLAISEN
PRO
KRIS NIKOLAISEN
Pro Student 51,941 Points

Exactly. Majors are English, Math, etc. And just like the instructions state: If the student's level is Junior or Senior ...

Students are created with a number of credits.

var student = new Student(3.9, 60);

Credits determine the level. And the level determines whether a major is set to a given value or 'None'.

So within the major() setter method

set major(major){
      if( this.level === 'Junior' || this.level === 'Senior' ){
        this._major = major;
      }
      else{
        this._major = 'None';
      }

    }
William Mead
William Mead
2,996 Points

Ok that worked. I could swear I tried that.

mehmet b.
mehmet b.
1,488 Points

Thanks, Kris for your support. It worked.