Welcome to the Treehouse Community

Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.

Start your free trial

JavaScript Object-Oriented JavaScript Getters and Setters Creating Setter Methods

Your setter method is returning the wrong value for the major property

I've watched the video over and still not sure why? I think it's some thing to do with the id?

creating_setters.js
class Student {
    constructor(gpa, credits){
        this.gpa = gpa;
        this.credits = credits;
    }

    stringGPA() {
        return this.gpa.toString();
    }

    get level() {
        if (this.credits > 90 ) {
            return 'Senior';
        } else if (this.credits > 60) {
            return 'Junior';
        } else if (this.credits > 30) {
            return 'Sophomore';
        } else {
            return 'Freshman';
        }
    }

     set major(major){
       this._major= major;
       if(this.level=== 'Senior'|| this.level==='Junior'){
         return this._major;
       }else if(this.level=== 'Freshmen' || this.level==='Sophomore'){
         return 'None';
        }
     }

}

var student = new Student(3.9, 60);

1 Answer

Guillermo Gallo
seal-mask
.a{fill-rule:evenodd;}techdegree
Guillermo Gallo
Full Stack JavaScript Techdegree Student 8,516 Points

Hi Daniel Corio-Rosas

You are on the right track. The first thing I see is that you have a spelling mistake, you wrote Freshmen instead of Freshman in your conditional. And secondly, and more importantly, you don’t need to return anything inside your setter method, setters are meant to set the value of a property not return them. So you should re-structure your conditional to set the _major property to major or to “none” depending on the value of level.

Hope this helps.