Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

Android Android Activity Lifecycle The Activity Lifecycle Retrieving Instance State

App immediately crash

I am suing string resources for my mFacts and mColors variables.

public class FactBook extends ContextWrapper {

    public String[] mFacts;

    public FactBook(Context base) {
        super(base);
    }

    // Fields (Member Variables) - Properties about the object
//    private final String[] mFacts = new String[]{
//            "Ants stretch when they wake up in the morning.",
//            "Ostriches can run faster than horses.",
//            "Olympic gold medals are actually made mostly of silver.",
//            "You are born with 300 bones; by the time you are an adult you will have 206.",
//            "It takes about 8 minutes for light from the Sun to reach Earth.",
//            "Some bamboo plants can grow almost a meter in just one day.",
//            "The state of Florida is bigger than England.",
//            "Some penguins can leap 2-3 meters out of the water.",
//            "On average, it takes 66 days to form a new habit.",
//            "Mammoths still walked the earth when the Great Pyramid was being built." };

    // Methods - Action the object can take
    public String getFact() {
        // Get the fact from XML file - strings.xml
        Resources res = getResources();
        mFacts = res.getStringArray(R.array.fact_book_en);
        // Randomly select a fact
        String fact;
        Random randomGenerator = new Random();
        int randomNumber = randomGenerator.nextInt(mFacts.length);
        fact = mFacts[randomNumber];
        return fact;
    }



}

When I do this on activity:

private String mFact = mFactBook.mFacts[0];

The app crash. Any way to solve this?

Ben Deitch

2 Answers

Seth Kroger
Seth Kroger
56,407 Points

Resources can't be accessed before onCreate because the Context necessary isn't completely filled in before that. Instead of initializing the variables that rely on android resources when declaring them. they need to be set/constructed in onCreate() or later in the lifecycle.

Ok thanks.