Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trial
qasimalbaqali
17,839 Points[Critique] Is my CSS written in a good way?
This is the first time I am coding in HTML CSS and soon will add some JS in my project which is about Tourism in Bahrian. I have illustrated some sights and want to make a one page website where some parts of the images will be moving as animation. So I just started the first two parts and want to know is the CSS I'm writing a good "practice" or I am doing it all wrong?
and here is the CSS (you won't see the images on code pen though just the HTML and CSS) http://codepen.io/anon/pen/raMGPx
Would really appreciate the feedback as this will be in my portfolio for my Uni application.
2 Answers
Ryan Duchene
Courses Plus Student 46,022 PointsIt looks pretty clean to me. :) Of course, there's not much CSS there to begin with (which is a good thing; having less code is better than having more.)
I wrote a big reply some time ago that went over good HTML and CSS practices. You can read it if you want, but you already seem to have pretty good standards in place. :)
Dustin Matlock
33,856 PointsYou might also be interested in CSS Guidelines.
Qasim Albaqali
Courses Plus Student 259 PointsQasim Albaqali
Courses Plus Student 259 PointsThank you! I will check it out. Is there anything I can adjust or change to keep the same positions and sizes but write it in a better way maybe?