Welcome to the Treehouse Community
Want to collaborate on code errors? Have bugs you need feedback on? Looking for an extra set of eyes on your latest project? Get support with fellow developers, designers, and programmers of all backgrounds and skill levels here with the Treehouse Community! While you're at it, check out some resources Treehouse students have shared here.
Looking to learn something new?
Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and join thousands of Treehouse students and alumni in the community today.
Start your free trialtomasvukasovic
24,022 PointsHowdy Treehouse Family, would you check this clients site?
Hey guys,
Well this is my first dynamic site developed in Django with some JS for a client of mine, the site is all done in spanish and I just wanted some reviews on it. The design wasn't made by me but sorta imposed by the client, so here is the link, also it would be great to have a course on deployment for Django, it was sort of a pain in the ass haha Kenneth Love
c437.cloud.wiroos.net
Kenneth Love
Treehouse Guest TeacherHaven't reviewed the code or anything yet but Deploying on Heroku and Deploying on PythonAnywhere
2 Answers
Aurelian Spodarec
10,801 PointsHey, is it your friend you are doing this for?
What do you want to check? The front-end stuff? Well, the design is pretty bad.
The code isn't the best either. I mean, there is little use of logic, such as, you make three columns by giving each row a unique class name, or id, and then you write to them the same style. What you could have done instead, is e.g. make it a class, (don't ever use id's, like really, only if they are really needed like for parallax effect), a class with, say you want to have articles, so you give the class or e.g. article or single-article, and assign it 33% or whatever width you want. That way you eliminated unecessary code, it's clearned and faster!
Now, the whole site is builded up on ids, repetition etc..
I coudl help you as much as I can, if you want, and maybe give you few guides, if you know CSS on what you could do.
The first one is actually comming on my slack channel, if you give me your email I can invite you. The second rule is maybe try to look at some architecture or something like OOCSS, SMACSS, and some naming convention like BEM for example. I will suggest you go throw the front-end track, watch every single video, and follow along, even if you think you know it.. watch it.. every singlesecond of it.. i did that. i though I knew it, i wasted a month.. while i could just have watched the basics, and here I'm after two months, 100% better.
The thrid step is to use a framework. Foundation or bootstrap. They will give you a nice convention to follow, which you will get the hint to learn so.
I hope this helps.
tomasvukasovic
24,022 PointsYes definitely the css is rubbish, I used to use Bootstrap but I didnt want to rely on using that. Front end Is not my fort haha I was thinking of redoing it, I will indeed take the tip thanks man! I was focused more on the BackEnd of the project rather than the Front. Do you have any good sited to take a look at OOCSS or SMACSS?
Aurelian Spodarec
10,801 PointsOh right, but if you want someone to review Django? then i don't know, but i think source code would be needed, like on github maybe I don't know :D but anywas, I don't know python, i suppose Django is python.
Well, first thing is I would suggest you to go and do treehouse tutorials here. https://teamtreehouse.com/library/modular-css-with-sass
I think that should or might be enough. At the end you can look at book o=under the title, but i will highlty sugest you to stick on one.. becaause HTML and CSS isn't as easy as it sounds it is. It requires a lot of work, which will take time, minimum 1-2months id say, tog et a good idea on it.
Kenneth Love
Treehouse Guest TeacherDon't run production sites with DEBUG = True
. http://c437.cloud.wiroos.net/something-404
tomasvukasovic
24,022 PointsThanks ken I forgot about that! manage.py check --deploy this command is pretty helpful
Aurelian Spodarec
10,801 PointsAurelian Spodarec
10,801 Points//Deleted, since there is answer below.
No option to delete this, so there it goes