Welcome to the Treehouse Community

The Treehouse Community is a meeting place for developers, designers, and programmers of all backgrounds and skill levels to get support. Collaborate here on code errors or bugs that you need feedback on, or asking for an extra set of eyes on your latest project. Join thousands of Treehouse students and alumni in the community today. (Note: Only Treehouse students can comment or ask questions, but non-students are welcome to browse our conversations.)

Looking to learn something new?

Treehouse offers a seven day free trial for new students. Get access to thousands of hours of content and a supportive community. Start your free trial today.

Python Django REST Framework Security and Customization Add Custom Field

Christopher Shaw
seal-mask
PLUS
.a{fill-rule:evenodd;}techdegree seal-36
Christopher Shaw
Python Web Development Techdegree Graduate 58,236 Points

Not sure how to solve the challenge.

No matter what I try, I keep getting 'Didn't get the right average for the game' Kenneth Love

scorekeeper/serializers.py
from django.db.models import Avg

from rest_framework import serializers

from . import models


class GameSerializer(serializers.ModelSerializer):
    average_score = serializers.SerializerMethodField()

    class Meta:
        fields = ('id', 'name', 'average_score')
        model = models.Game

    def get_average_rating(self, obj):
      average = Game.objects.all().aggregate(Avg('scores')).get('scores__avg')

      if average is None:
        return 0

      return average

class PlayerSerializer(serializers.ModelSerializer):
    class Meta:
        fields = ('id', 'name', 'age', 'parent_approval')
        model = models.Player

    def validate(self, data):
        if data['age'] < 13 and not data['parent_approval']:
            raise serializers.ValidationError(
                "Children under 13 require parental approval"
            )
        return data


class ScoreSerializer(serializers.ModelSerializer):
    game = serializers.HyperlinkedRelatedField(
        read_only=True, view_name='apiv2:game-detail')
    player = serializers.HyperlinkedRelatedField(
        read_only=True, view_name='apiv2:player-detail')

    class Meta:
        fields = ('id', 'game', 'player', 'score')
        model = models.Score

1 Answer

Kenneth Love
STAFF
Kenneth Love
Treehouse Guest Teacher

Your field and method names have to match up, with the method name having get_ on the front of it.